Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1103)

Issue 8551048: environs/cloudinit: increase fd limit for mongodb (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by dfc
Modified:
9 years, 6 months ago
Reviewers:
mp+161276, dimitern, rog
Visibility:
Public.

Description

environs/cloudinit: increase fd limit for mongodb https://code.launchpad.net/~dave-cheney/juju-core/119-fix-mongo-ulimits/+merge/161276 Requires: https://code.launchpad.net/~dave-cheney/juju-core/120-upstart-add-limit-verb/+merge/161275 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : environs/cloudinit: increase fd limit for mongodb #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -8 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M environs/cloudinit/cloudinit.go View 1 3 chunks +14 lines, -2 lines 0 comments Download
M environs/cloudinit/cloudinit_test.go View 5 chunks +5 lines, -5 lines 0 comments Download
M upstart/upstart.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
dfc
Please take a look.
9 years, 7 months ago (2013-04-27 05:59:43 UTC) #1
dfc
On 2013/04/27 05:59:43, dfc wrote: > Please take a look. ping
9 years, 7 months ago (2013-04-29 05:14:15 UTC) #2
dimitern
LGTM with one suggestion. https://codereview.appspot.com/8551048/diff/1/environs/cloudinit/cloudinit.go File environs/cloudinit/cloudinit.go (right): https://codereview.appspot.com/8551048/diff/1/environs/cloudinit/cloudinit.go#newcode301 environs/cloudinit/cloudinit.go:301: "nofile": fmt.Sprintf("%d %d", max(maxConns, 65000), ...
9 years, 7 months ago (2013-04-29 09:59:58 UTC) #3
rog
LGTM with one suggestion slightly different from dimiter's. https://codereview.appspot.com/8551048/diff/1/environs/cloudinit/cloudinit.go File environs/cloudinit/cloudinit.go (right): https://codereview.appspot.com/8551048/diff/1/environs/cloudinit/cloudinit.go#newcode301 environs/cloudinit/cloudinit.go:301: "nofile": ...
9 years, 7 months ago (2013-04-29 10:11:06 UTC) #4
rog
On 2013/04/29 10:11:06, rog wrote: > LGTM with one suggestion slightly different from dimiter's. > ...
9 years, 7 months ago (2013-04-29 10:11:51 UTC) #5
dfc
9 years, 7 months ago (2013-04-30 05:40:39 UTC) #6
*** Submitted:

environs/cloudinit: increase fd limit for mongodb

R=dimitern, rog
CC=
https://codereview.appspot.com/8551048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b