environs/cloudinit: increase fd limit for mongodb

environs/cloudinit: increase fd limit for mongodb



https://code.launchpad.net/~dave-cheney/juju-core/119-fix-mongo-ulimits/+merge/161276

Requires: https://code.launchpad.net/~dave-cheney/juju-core/120-upstart-add-limit-verb/+merge/161275

(do not edit description out of merge proposal)

[dfc, 2013-04-27 05:59:43]

Please take a look.

[dfc, 2013-04-29 05:14:15]

On 2013/04/27 05:59:43, dfc wrote:
> Please take a look.

ping

[dimitern, 2013-04-29 09:59:58]

LGTM with one suggestion.

https://codereview.appspot.com/8551048/diff/1/environs/cloudinit/cloudinit.go
File environs/cloudinit/cloudinit.go (right):

https://codereview.appspot.com/8551048/diff/1/environs/cloudinit/cloudinit.go...
environs/cloudinit/cloudinit.go:301: "nofile": fmt.Sprintf("%d %d",
max(maxConns, 65000), max(maxConns, 65000)),
should we have var maxFiles = max(maxConns, 65000) up there and use it here
twice?

[rog, 2013-04-29 10:11:06]

LGTM with one suggestion slightly different from dimiter's.

https://codereview.appspot.com/8551048/diff/1/environs/cloudinit/cloudinit.go
File environs/cloudinit/cloudinit.go (right):

https://codereview.appspot.com/8551048/diff/1/environs/cloudinit/cloudinit.go...
environs/cloudinit/cloudinit.go:301: "nofile": fmt.Sprintf("%d %d",
max(maxConns, 65000), max(maxConns, 65000)),
i think we should put all the constants up at the top of the file.
const (
     maxMongoFiles = 65000
     maxAgentFiles = 20000
)

rather than trying to pretend that they're the same thing
with the same maxConns constant.

[rog, 2013-04-29 10:11:51]

On 2013/04/29 10:11:06, rog wrote:
> LGTM with one suggestion slightly different from dimiter's.
> 
> https://codereview.appspot.com/8551048/diff/1/environs/cloudinit/cloudinit.go
> File environs/cloudinit/cloudinit.go (right):
> 
>
https://codereview.appspot.com/8551048/diff/1/environs/cloudinit/cloudinit.go...
> environs/cloudinit/cloudinit.go:301: "nofile": fmt.Sprintf("%d %d",
> max(maxConns, 65000), max(maxConns, 65000)),
> i think we should put all the constants up at the top of the file.
> const (
>      maxMongoFiles = 65000
>      maxAgentFiles = 20000
> )
> 
> rather than trying to pretend that they're the same thing
> with the same maxConns constant.

(and lose the unnecessary max logic)

[dfc, 2013-04-30 05:40:39]

*** Submitted:

environs/cloudinit: increase fd limit for mongodb

R=dimitern, rog
CC=
https://codereview.appspot.com/8551048