Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2671)

Issue 84190043: Ported r2559 from trunk to 1.18 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by cmars
Modified:
10 years ago
Reviewers:
wwitzel, mp+214097, wallyworld, Nate Finch
Visibility:
Public.

Description

Ported r2559 from trunk to 1.18 For the deploy and upgradecharm commands, when a series is not provided, and a default-series is not set in the environment config, the client will resolve the series with the charm store, through the state server. If the client is working with a 1.16 state server, it will resolve the series directly with the charm store. Existing environments will have a default-series, so they should have no change in series selection. New environments will continue to support the default-series config setting, but it can be omitted, and is not set by default. https://code.launchpad.net/~cmars/juju-core/1.18-resolve-cs-series/+merge/214097 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Ported r2559 from trunk to 1.18 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -5 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/juju/common.go View 1 2 chunks +8 lines, -0 lines 0 comments Download
M cmd/juju/deploy.go View 1 2 chunks +8 lines, -5 lines 0 comments Download
M provider/local/environprovider.go View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5
cmars
Please take a look.
10 years ago (2014-04-03 19:20:56 UTC) #1
cmars
This is a cherry-pick of r2559 from trunk. Original trunk proposal, for context: https://codereview.appspot.com/80280043/ PTAL ...
10 years ago (2014-04-03 19:30:29 UTC) #2
wallyworld
Cherry pick looks ok. Only reviewed for obvious backporting errors as original work was approved.
10 years ago (2014-04-03 23:19:37 UTC) #3
cmars
Please take a look.
10 years ago (2014-04-09 22:49:16 UTC) #4
cmars
10 years ago (2014-04-09 22:51:29 UTC) #5
On 2014/04/09 22:49:16, cmars wrote:
> Please take a look.

lbox picked up the wrong branch here, please ignore.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b