Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(340)

Issue 80280043: Resolve series with charm store in juju client.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by cmars
Modified:
9 years, 12 months ago
Reviewers:
mp+212755, john2, jameinel, wallyworld, fwereade, curtis
Visibility:
Public.

Description

Resolve series with charm store in juju client. For the deploy and upgradecharm commands, when a series is not provided, and a default-series is not set in the environment config, the client will resolve the series with the charm store, through the state server. If the client is working with a 1.16 state server, it will resolve the series directly with the charm store. Existing environments will have a default-series, so they should have no change in series selection. New environments will continue to support the default-series config setting, but it can be omitted, and is not set by default. https://code.launchpad.net/~cmars/juju-core/resolve-cs-series/+merge/212755 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 8

Patch Set 2 : Resolve series with charm store in juju client. #

Total comments: 16

Patch Set 3 : Resolve series with charm store in juju client. #

Patch Set 4 : Resolve series with charm store in juju client. #

Total comments: 16

Patch Set 5 : Resolve series with charm store in juju client. #

Patch Set 6 : Resolve series with charm store in juju client. #

Patch Set 7 : Resolve series with charm store in juju client. #

Total comments: 23

Patch Set 8 : Resolve series with charm store in juju client. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+443 lines, -151 lines) Patch
A [revision details] View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M charm/charm.go View 2 chunks +5 lines, -5 lines 0 comments Download
M charm/charm_test.go View 2 chunks +4 lines, -4 lines 0 comments Download
M charm/url.go View 1 2 3 4 5 6 7 2 chunks +17 lines, -2 lines 0 comments Download
M charm/url_test.go View 1 2 3 4 5 6 7 2 chunks +14 lines, -1 line 1 comment Download
M cmd/juju/addmachine.go View 1 2 3 4 5 6 7 2 chunks +2 lines, -1 line 0 comments Download
M cmd/juju/bootstrap_test.go View 1 2 3 4 5 6 7 13 chunks +33 lines, -20 lines 0 comments Download
M cmd/juju/common.go View 1 2 3 4 5 6 7 2 chunks +39 lines, -0 lines 0 comments Download
M cmd/juju/deploy.go View 1 2 3 4 5 6 7 2 chunks +14 lines, -11 lines 0 comments Download
M cmd/juju/environment_test.go View 1 2 3 4 1 chunk +14 lines, -4 lines 0 comments Download
M cmd/juju/publish.go View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M cmd/juju/upgradecharm.go View 1 2 3 4 5 6 7 4 chunks +6 lines, -11 lines 0 comments Download
M cmd/juju/upgradejuju_test.go View 1 2 3 4 5 7 chunks +10 lines, -6 lines 0 comments Download
M cmd/plugins/juju-metadata/imagemetadata.go View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M cmd/plugins/juju-metadata/imagemetadata_test.go View 1 2 3 4 5 4 chunks +4 lines, -2 lines 0 comments Download
M environs/bootstrap/bootstrap_test.go View 1 2 3 4 7 chunks +16 lines, -9 lines 0 comments Download
M environs/bootstrap/synctools.go View 1 2 3 4 2 chunks +8 lines, -3 lines 0 comments Download
M environs/config/config.go View 1 2 3 4 5 6 7 7 chunks +59 lines, -8 lines 0 comments Download
M environs/config/config_test.go View 1 2 3 4 5 6 7 4 chunks +7 lines, -6 lines 0 comments Download
M environs/jujutest/livetests.go View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M environs/testing/tools.go View 1 2 3 4 4 chunks +9 lines, -8 lines 0 comments Download
M juju/apiconn_test.go View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M juju/testing/conn.go View 1 2 3 4 4 chunks +15 lines, -2 lines 0 comments Download
M juju/testing/instance.go View 1 2 3 4 5 6 7 2 chunks +2 lines, -1 line 0 comments Download
M provider/azure/environ_test.go View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M provider/common/bootstrap.go View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M provider/dummy/environs.go View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M provider/ec2/ec2.go View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M provider/ec2/live_test.go View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M provider/ec2/local_test.go View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M provider/joyent/environ.go View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M provider/openstack/provider.go View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M state/api/client.go View 1 2 3 4 5 6 7 1 chunk +18 lines, -0 lines 0 comments Download
M state/api/params/params.go View 1 2 3 4 5 6 7 1 chunk +16 lines, -0 lines 0 comments Download
M state/apiserver/client/client.go View 1 2 3 4 5 6 7 5 chunks +40 lines, -13 lines 0 comments Download
M state/apiserver/client/client_test.go View 1 2 3 4 5 6 7 6 chunks +60 lines, -5 lines 0 comments Download
M testing/environ.go View 1 2 3 4 5 6 7 2 chunks +3 lines, -1 line 0 comments Download
M worker/provisioner/container_initialisation_test.go View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M worker/provisioner/kvm-broker_test.go View 1 2 3 4 5 6 7 4 chunks +3 lines, -4 lines 0 comments Download
M worker/provisioner/lxc-broker_test.go View 1 2 3 4 5 6 7 4 chunks +3 lines, -4 lines 0 comments Download
M worker/provisioner/provisioner_test.go View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 21
cmars
Please take a look.
10 years ago (2014-03-26 02:00:14 UTC) #1
cmars
This is the client-side to support the LTS transition to trusty (LP: #1290824). It can't ...
10 years ago (2014-03-26 02:10:29 UTC) #2
jameinel
I think we have some common code that should be factored out, and I think ...
10 years ago (2014-03-26 07:11:16 UTC) #3
cmars
PTAL. If everything looks ok, I'd still like to run a few more tests against ...
10 years ago (2014-03-27 04:05:17 UTC) #4
cmars
Please take a look.
10 years ago (2014-03-27 04:09:00 UTC) #5
cmars
The necessary charm store updates to support this change have been deployed to store.juju.ubuntu.com. It ...
10 years ago (2014-03-27 18:25:24 UTC) #6
fwereade
A few issues -- don't think any of them should be too much hassle to ...
10 years ago (2014-03-28 10:43:10 UTC) #7
cmars
Please take a look.
10 years ago (2014-03-31 19:37:32 UTC) #8
cmars
https://codereview.appspot.com/80280043/diff/20001/environs/config/config.go File environs/config/config.go (left): https://codereview.appspot.com/80280043/diff/20001/environs/config/config.go#oldcode411 environs/config/config.go:411: func (c *Config) DefaultSeries() string { On 2014/03/28 10:43:11, ...
10 years ago (2014-03-31 19:57:06 UTC) #9
cmars
Please take a look.
10 years ago (2014-03-31 19:58:10 UTC) #10
fwereade
Nearly there -- a quibble with the location of the PreferredSeries code, and a bit ...
9 years, 12 months ago (2014-04-01 07:10:07 UTC) #11
cmars
Thanks for reviewing. Couple of questions: https://codereview.appspot.com/80280043/diff/60001/cmd/juju/addmachine.go File cmd/juju/addmachine.go (right): https://codereview.appspot.com/80280043/diff/60001/cmd/juju/addmachine.go#newcode129 cmd/juju/addmachine.go:129: series = conf.PreferredSeries() ...
9 years, 12 months ago (2014-04-01 15:05:11 UTC) #12
cmars
Please take a look.
9 years, 12 months ago (2014-04-02 03:55:11 UTC) #13
cmars
I've addressed most of the feedback, but there is a problem lurking. When config.LatestLtsSeries() == ...
9 years, 12 months ago (2014-04-02 04:20:03 UTC) #14
cmars
Please take a look.
9 years, 12 months ago (2014-04-02 17:08:11 UTC) #15
cmars
Tests affected by the LTS change wrt uploading tools are now all passing when the ...
9 years, 12 months ago (2014-04-02 17:16:21 UTC) #16
cmars
Please take a look.
9 years, 12 months ago (2014-04-02 22:08:19 UTC) #17
wallyworld
I think the tools changes are ok. What I like is that when we start ...
9 years, 12 months ago (2014-04-03 03:02:56 UTC) #18
fwereade
Looks good, would appreciate at least a short chat before landing -- in particular, I'm ...
9 years, 12 months ago (2014-04-03 13:34:14 UTC) #19
cmars
PTAL https://codereview.appspot.com/80280043/diff/120001/cmd/juju/bootstrap_test.go File cmd/juju/bootstrap_test.go (right): https://codereview.appspot.com/80280043/diff/120001/cmd/juju/bootstrap_test.go#newcode123 cmd/juju/bootstrap_test.go:123: useVersion := strings.Replace(test.version, "%LTS%", config.LatestLtsSeries(), 1) On 2014/04/03 ...
9 years, 12 months ago (2014-04-03 16:11:42 UTC) #20
fwereade
9 years, 12 months ago (2014-04-03 17:17:11 UTC) #21
LGTM with one trivial. Thanks for this, it's a monster diff -- let's throw it at
CI and see what we've missed ;).

https://codereview.appspot.com/80280043/diff/140001/charm/url_test.go
File charm/url_test.go (right):

https://codereview.appspot.com/80280043/diff/140001/charm/url_test.go#newcode292
charm/url_test.go:292: c.Check(parsed, gc.DeepEquals, ref)
add one for unmarshalling gibberish, just for safety's sake
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b