Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(389)

Issue 8092048: code review 8092048: go.exp/go/types: better error message for non-existing ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 9 months ago by gri
Modified:
8 years, 9 months ago
Reviewers:
CC:
golang-dev, r, remyoudompheng
Visibility:
Public.

Description

go.exp/go/types: better error message for non-existing qualified idents Fixes issue 4967.

Patch Set 1 #

Patch Set 2 : diff -r 2cd982aef585 https://code.google.com/p/go.exp #

Patch Set 3 : diff -r 2cd982aef585 https://code.google.com/p/go.exp #

Total comments: 1

Patch Set 4 : diff -r 2cd982aef585 https://code.google.com/p/go.exp #

Patch Set 5 : diff -r 2cd982aef585 https://code.google.com/p/go.exp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M go/types/expr.go View 1 2 3 1 chunk +8 lines, -5 lines 0 comments Download
M go/types/testdata/decls0.src View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M go/types/testdata/decls1.src View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8
gri
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.exp
8 years, 9 months ago (2013-04-01 21:00:45 UTC) #1
r
LGTM
8 years, 9 months ago (2013-04-01 21:17:40 UTC) #2
remyoudompheng
https://codereview.appspot.com/8092048/diff/5001/go/types/expr.go File go/types/expr.go (right): https://codereview.appspot.com/8092048/diff/5001/go/types/expr.go#newcode1149 go/types/expr.go:1149: check.errorf(e.Pos(), "%s does not exist", e) Is it idiomatic ...
8 years, 9 months ago (2013-04-01 21:20:13 UTC) #3
r
sure, better wording is always better.
8 years, 9 months ago (2013-04-01 21:21:43 UTC) #4
gri
Hello golang-dev@googlegroups.com, r@golang.org, remyoudompheng@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
8 years, 9 months ago (2013-04-01 21:48:22 UTC) #5
r
LGTM but wait for remy
8 years, 9 months ago (2013-04-01 21:54:15 UTC) #6
remyoudompheng
LGTM
8 years, 9 months ago (2013-04-01 21:56:55 UTC) #7
gri
8 years, 9 months ago (2013-04-01 22:15:49 UTC) #8
*** Submitted as
https://code.google.com/p/go/source/detail?r=ea93dd8028b8&repo=exp ***

go.exp/go/types: better error message for non-existing qualified idents

Fixes issue 4967.

R=golang-dev, r, remyoudompheng
CC=golang-dev
https://codereview.appspot.com/8092048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b