code review 8092048: go.exp/go/types: better error message for non-existing ...

go.exp/go/types: better error message for non-existing qualified idents

Fixes issue 4967.

[gri, 2013-04-01 21:00:45]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.exp

[r, 2013-04-01 21:17:40]

LGTM

[remyoudompheng, 2013-04-01 21:20:13]

https://codereview.appspot.com/8092048/diff/5001/go/types/expr.go
File go/types/expr.go (right):

https://codereview.appspot.com/8092048/diff/5001/go/types/expr.go#newcode1149
go/types/expr.go:1149: check.errorf(e.Pos(), "%s does not exist", e)
Is it idiomatic errorese to say that "math.xxx does not exist"?

I would usually read something like "no such identifier in package math: xxx",
but if r agrees, I withdraw my objection.

[r, 2013-04-01 21:21:43]

sure, better wording is always better.

[gri, 2013-04-01 21:48:22]

Hello golang-dev@googlegroups.com, r@golang.org, remyoudompheng@gmail.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[r, 2013-04-01 21:54:15]

LGTM but wait for remy

[remyoudompheng, 2013-04-01 21:56:55]

LGTM

[gri, 2013-04-01 22:15:49]

*** Submitted as
https://code.google.com/p/go/source/detail?r=ea93dd8028b8&repo=exp ***

go.exp/go/types: better error message for non-existing qualified idents

Fixes issue 4967.

R=golang-dev, r, remyoudompheng
CC=golang-dev
https://codereview.appspot.com/8092048