Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(563)

Issue 7760044: go.crypto/sha3: new package

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years ago by jcb
Modified:
7 years ago
Reviewers:
agl1
CC:
agl1, nigeltao, golang-dev
Visibility:
Public.

Description

go.crypto/sha3: new package Added a pure Go implementation of SHA3 (Keccak) which implements the hash.Hash interface. A test file is included with performance benchmarks and standard test vectors.

Patch Set 1 #

Patch Set 2 : code review 7760044: sha3/: new package #

Patch Set 3 : code review 7760044: sha3/: new package #

Patch Set 4 : diff -r 8dd5caec1eae https://code.google.com/p/go.crypto/ #

Total comments: 97

Patch Set 5 : diff -r 8dd5caec1eae https://code.google.com/p/go.crypto/ #

Patch Set 6 : diff -r 8dd5caec1eae https://code.google.com/p/go.crypto/ #

Total comments: 36

Patch Set 7 : diff -r 8dd5caec1eae https://code.google.com/p/go.crypto/ #

Total comments: 18

Patch Set 8 : diff -r 8dd5caec1eae https://code.google.com/p/go.crypto/ #

Patch Set 9 : diff -r 8dd5caec1eae https://code.google.com/p/go.crypto/ #

Total comments: 8

Patch Set 10 : diff -r 8dd5caec1eae https://code.google.com/p/go.crypto/ #

Patch Set 11 : diff -r 8dd5caec1eae https://code.google.com/p/go.crypto/ #

Patch Set 12 : diff -r 8dd5caec1eae https://code.google.com/p/go.crypto/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+634 lines, -0 lines) Patch
A sha3/keccakf.go View 1 2 3 4 5 1 chunk +171 lines, -0 lines 0 comments Download
A sha3/sha3.go View 1 2 3 4 5 6 7 8 9 1 chunk +216 lines, -0 lines 0 comments Download
A sha3/sha3_test.go View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +247 lines, -0 lines 0 comments Download

Messages

Total messages: 21
jcb
7 years ago (2013-03-19 17:49:02 UTC) #1
jcb
7 years ago (2013-03-19 17:55:46 UTC) #2
nigeltao
agl leads the go.crypto sub-repository, and https://groups.google.com/d/msg/golang-dev/clWZwaQz9cs/rJ5zORSKk20J suggests that he's not in favor of including ...
7 years ago (2013-03-20 00:56:29 UTC) #3
agl1
On Tue, Mar 19, 2013 at 8:56 PM, <nigeltao@golang.org> wrote: > suggests that he's not ...
7 years ago (2013-03-20 01:11:32 UTC) #4
nigeltao
In general, your top-level // comment lines are uncomfortably long. I'd break it at somewhere ...
7 years ago (2013-03-20 02:17:43 UTC) #5
nigeltao
https://codereview.appspot.com/7760044/diff/7001/sha3/sha3internal.go File sha3/sha3internal.go (right): https://codereview.appspot.com/7760044/diff/7001/sha3/sha3internal.go#newcode1 sha3/sha3internal.go:1: // Copyright 2012 The Go Authors. All rights reserved. ...
7 years ago (2013-03-20 02:22:15 UTC) #6
agl1
https://codereview.appspot.com/7760044/diff/7001/sha3/sha3.go File sha3/sha3.go (right): https://codereview.appspot.com/7760044/diff/7001/sha3/sha3.go#newcode39 sha3/sha3.go:39: var padOpen = [laneSize]uint64{ Was this the result of ...
7 years ago (2013-03-20 14:48:50 UTC) #7
jcb
Here are fixes for the issues you brought up. With some of the optimizations suggested ...
7 years ago (2013-03-20 23:36:15 UTC) #8
nigeltao
https://codereview.appspot.com/7760044/diff/7001/sha3/sha3_test.go File sha3/sha3_test.go (right): https://codereview.appspot.com/7760044/diff/7001/sha3/sha3_test.go#newcode46 sha3/sha3_test.go:46: switch t.inputHex { On 2013/03/20 23:36:16, jcb wrote: > ...
7 years ago (2013-03-21 02:36:49 UTC) #9
nigeltao
Also change the CL description opening line from: sha3/: new package to go.crypto/sha3: new package.
7 years ago (2013-03-21 02:37:48 UTC) #10
jcb
I think we're down to two issues of how the test vectors are stored-I think ...
7 years ago (2013-03-21 19:06:25 UTC) #11
agl1
LGTM with nits. If Nigel says LGTM then I'll land it. https://codereview.appspot.com/7760044/diff/27001/sha3/sha3.go File sha3/sha3.go (right): ...
7 years ago (2013-03-21 20:27:23 UTC) #12
jcb
Fixed nits plus two substantial items: *Changed the squeeze() function to only allocate one or ...
7 years ago (2013-03-22 01:00:38 UTC) #13
nigeltao
https://codereview.appspot.com/7760044/diff/7001/sha3/sha3_test.go File sha3/sha3_test.go (right): https://codereview.appspot.com/7760044/diff/7001/sha3/sha3_test.go#newcode46 sha3/sha3_test.go:46: switch t.inputHex { On 2013/03/21 19:06:25, jcb wrote: > ...
7 years ago (2013-03-22 04:21:21 UTC) #14
jcb
Test code cleaned up. https://codereview.appspot.com/7760044/diff/7001/sha3/sha3_test.go File sha3/sha3_test.go (right): https://codereview.appspot.com/7760044/diff/7001/sha3/sha3_test.go#newcode46 sha3/sha3_test.go:46: switch t.inputHex { On 2013/03/22 ...
7 years ago (2013-03-22 16:15:51 UTC) #15
agl1
On Fri, Mar 22, 2013 at 12:15 PM, <jcb@google.com> wrote: > Test code cleaned up. ...
7 years ago (2013-03-22 16:37:02 UTC) #16
jcb
Hmmm, alternative is that there are upstream test vectors of up to 4KB, but they ...
7 years ago (2013-03-22 16:47:38 UTC) #17
agl1
On Fri, Mar 22, 2013 at 12:47 PM, Joseph Bonneau <jcb@google.com> wrote: > Hmmm, alternative ...
7 years ago (2013-03-22 16:52:20 UTC) #18
jcb
Took 30 min, but the Python code confirmed these. On Fri, Mar 22, 2013 at ...
7 years ago (2013-03-22 18:22:19 UTC) #19
jcb
Uploaded a final CL with these test vectors On Fri, Mar 22, 2013 at 2:22 ...
7 years ago (2013-03-22 18:22:55 UTC) #20
agl1
7 years ago (2013-03-22 19:00:11 UTC) #21
*** Submitted as
https://code.google.com/p/go/source/detail?r=87c30004e36a&repo=crypto ***

go.crypto/sha3: new package
Added a pure Go implementation of SHA3 (Keccak) which implements the hash.Hash
interface.
A test file is included with performance benchmarks and standard test vectors.

R=agl, nigeltao
CC=golang-dev
https://codereview.appspot.com/7760044

Committer: Adam Langley <agl@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b