Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(70)

Issue 7757044: Fix setting of StopIteration and GeneratorReturn. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by usrbincc
Modified:
13 years, 2 months ago
Reviewers:
slightlylate, arv
CC:
traceur-compiler-reviews_googlegroups.com
Base URL:
https://code.google.com/p/traceur-compiler/@master
Visibility:
Public.

Description

Fix setting of StopIteration and GeneratorReturn. - Set the global StopIteration correctly in the 'undefined' case. - Use getters so that the effects of setStopIteration, etc, show up in traceur.runtime.StopIteration, etc. Previously it was only updated during runtime initialization. BUG=None TEST=test/feature/Yield/StopIteration.js

Patch Set 1 #

Total comments: 2

Patch Set 2 : Merge master at 4b95bde73a18eb81 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -3 lines) Patch
M src/runtime/runtime.js View 1 2 chunks +7 lines, -3 lines 0 comments Download
A test/feature/Yield/StopIteration.js View 1 chunk +80 lines, -0 lines 1 comment Download

Messages

Total messages: 3
usrbincc
Patch order at a glance: Add isStopIteration to '@iter' module. Update the tests to use ...
13 years, 3 months ago (2013-03-13 20:26:38 UTC) #1
usrbincc
Note: I'm just cleaning out old issues. New patches will go through github once I ...
13 years, 2 months ago (2013-03-30 16:33:33 UTC) #2
arv
13 years, 2 months ago (2013-04-02 18:05:13 UTC) #3
LGTM

Committed as 3758de5d46486130dd733f14fb6a01a65329ca24

https://codereview.appspot.com/7757044/diff/10001/test/feature/Yield/StopIter...
File test/feature/Yield/StopIteration.js (right):

https://codereview.appspot.com/7757044/diff/10001/test/feature/Yield/StopIter...
test/feature/Yield/StopIteration.js:1: import isStopIteration from '@iter';
import {isStopIteration} from '@iter';

I wen't through all of these once before in preparation for modules v2.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b