Issue 77210043: code review 77210043: undo CL 77050045 / 073d79675aae

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 77210043: code review 77210043: undo CL 77050045 / 073d79675aae (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by bradfitz

Modified:
11 years, 2 months ago

Reviewers:

CC:
cmang, golang-codereviews

Visibility:
Public.

Description

undo CL 77050045 / 073d79675aae Breaks all builds. ««« original CL description cmd/gc: Add tests for self-referential array types. LGTM=gri, iant R=gri, iant CC=golang-codereviews https://codereview.appspot.com/77050045 »»»

Patch Set 1 #

Patch Set 2 : diff -r abda832be00f https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r abda832be00f https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r abda832be00f https://go.googlecode.com/hg/ #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -19 lines)			Patch
	R	test/fixedbugs/issue7525.go	View	1	1 chunk	+0 lines, -19 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bradfitz

Hello cmang@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 2 months ago (2014-03-18 02:56:10 UTC) #1

bradfitz

11 years, 2 months ago (2014-03-18 03:00:44 UTC) #2

*** Submitted as https://code.google.com/p/go/source/detail?r=723d505b1a89 ***

undo CL 77050045 / 073d79675aae

Breaks all builds.

««« original CL description
cmd/gc: Add tests for self-referential array types.

LGTM=gri, iant
R=gri, iant
CC=golang-codereviews
https://codereview.appspot.com/77050045
»»»

TBR=cmang
R=cmang
CC=golang-codereviews
https://codereview.appspot.com/77210043

Expand All Messages | Collapse All Messages