Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(237)

Issue 77050045: code review 77050045: cmd/gc: Add tests for self-referential array types. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by cmang
Modified:
11 years, 2 months ago
Reviewers:
gobot, gri, iant, bradfitz
CC:
gri, iant, golang-codereviews
Visibility:
Public.

Description

cmd/gc: Add tests for self-referential array types.

Patch Set 1 #

Patch Set 2 : diff -r 2162d6893121 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 2162d6893121 https://code.google.com/p/go.tools #

Patch Set 4 : diff -r 740f2c9af41e https://code.google.com/p/go #

Patch Set 5 : diff -r 740f2c9af41e https://code.google.com/p/go #

Patch Set 6 : diff -r 740f2c9af41e https://code.google.com/p/go #

Patch Set 7 : diff -r 740f2c9af41e https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
A test/fixedbugs/issue7525.go View 1 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 6
cmang
Hello gri@golang.org, iant@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools
11 years, 2 months ago (2014-03-17 23:23:03 UTC) #1
gri
lgtm
11 years, 2 months ago (2014-03-17 23:54:10 UTC) #2
iant
LGTM but make sure that the gc script all.bash passes before you submit it.
11 years, 2 months ago (2014-03-18 00:00:53 UTC) #3
cmang
*** Submitted as https://code.google.com/p/go/source/detail?r=073d79675aae *** cmd/gc: Add tests for self-referential array types. LGTM=gri, iant R=gri, ...
11 years, 2 months ago (2014-03-18 01:30:11 UTC) #4
gobot
This CL appears to have broken the darwin-amd64 builder. See http://build.golang.org/log/3820b618e8ab5ec8ae9a09c51cd4493a5542e235
11 years, 2 months ago (2014-03-18 01:36:40 UTC) #5
bradfitz
11 years, 2 months ago (2014-03-18 02:55:23 UTC) #6
Message was sent while issue was closed.
This broke the world.  Apparently all.bash didn't pass, as Ian was wise to warn
about trying to run first.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b