|
|
Created:
11 years, 1 month ago by rick Modified:
11 years, 1 month ago Reviewers:
CC:
golang-dev, pah, minux1, adg Visibility:
Public. |
Descriptiondoc/contribute: add instructions to fix codereview on windows
Tell Windows users how to update Mercurial's library.zip to add some missing dependencies.
Fixes issue 4745.
Patch Set 1 #Patch Set 2 : diff -r e7e2b3ec4717 https://code.google.com/p/go #Patch Set 3 : diff -r e7e2b3ec4717 https://code.google.com/p/go #Patch Set 4 : diff -r e7e2b3ec4717 https://code.google.com/p/go #
Total comments: 1
Patch Set 5 : diff -r e7e2b3ec4717 https://code.google.com/p/go #MessagesTotal messages: 16
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
Sign in to reply to this message.
LGTM I had to do this two days ago, thanks for documenting it.
Sign in to reply to this message.
I've done this (make codereview working on windows) once. And it seems the exact list of files needed is dependent on the version of mercurial. For example, for hg 2.1.1 I only need two of the files, and need to extract them from Python 2.6 instead of 2.7. Explaining all this will complicate the presentation greatly, so I see two alternatives here: 1. add this info to go-wiki, and point it from here (a candidate page is: InstallFromSource or perhaps GoGetTools) 2. simply recommending windows user to first install Python and then install mercurial from source [not compiling from source, i mean the source install from mercurial download page]?
Sign in to reply to this message.
If installing Python and then installing the Mercurial source packages is takes around the same amount of time as the steps in this CL, that seems like the way to go. You need to install Python anyway to be able to copy the files and MingW gcc to compile Go. I just tried it and it took longer and required more fiddling with my PATH, but worked out. I had to use the pure Python version because the compile failed. My concern about this approach is that it goes against the warnings on the Mercurial site, which instruct to not install from source. On Thu, Mar 7, 2013 at 8:35 AM, <minux.ma@gmail.com> wrote: > I've done this (make codereview working on windows) once. > And it seems the exact list of files needed is dependent on the version > of mercurial. > > For example, for hg 2.1.1 I only need two of the files, and need to > extract > them from Python 2.6 instead of 2.7. > > Explaining all this will complicate the presentation greatly, > so I see two alternatives here: > 1. add this info to go-wiki, and point it from here > (a candidate page is: InstallFromSource or perhaps GoGetTools) > 2. simply recommending windows user to first install Python and > then install mercurial from source [not compiling from source, i > mean the source install from mercurial download page]? > > https://codereview.appspot.**com/7558043/<https://codereview.appspot.com/7558... >
Sign in to reply to this message.
On Fri, Mar 8, 2013 at 12:57 AM, Patrick Higgins <patrick.allen.higgins@gmail.com> wrote: > If installing Python and then installing the Mercurial source packages is > takes around the same amount of time as the steps in this CL, that seems > like the way to go. You need to install Python anyway to be able to copy the > files and MingW gcc to compile Go. what does the "Mercurial 2.5.2 for Python 2.7 on Windows x86 (source install)" on the mercurial download page do? i expect it to require a prior installed Python 2.7.
Sign in to reply to this message.
On Thu, Mar 7, 2013 at 10:09 AM, minux <minux.ma@gmail.com> wrote: > what does the "Mercurial 2.5.2 for Python 2.7 on Windows x86 (source > install)" > on the mercurial download page do? i expect it to require a prior > installed Python 2.7. There are two sources, apparently. I used http://mercurial.selenic.com/wiki/Download#Source_packages but after seeing your comment found http://mercurial.selenic.com/downloads/ and it was much easier to install. It checks the registry for the Python 2.7 install location and then installs it. I had to manually add c:\python27 and c:\python27\scripts to my PATH, but that method is clean and easy.
Sign in to reply to this message.
On Fri, Mar 8, 2013 at 2:46 AM, Patrick Higgins <patrick.allen.higgins@gmail.com> wrote: > On Thu, Mar 7, 2013 at 10:09 AM, minux <minux.ma@gmail.com> wrote: >> >> what does the "Mercurial 2.5.2 for Python 2.7 on Windows x86 (source >> install)" >> on the mercurial download page do? i expect it to require a prior >> installed Python 2.7. > There are two sources, apparently. I used > http://mercurial.selenic.com/wiki/Download#Source_packages but after seeing > your comment found http://mercurial.selenic.com/downloads/ and it was much > easier to install. It checks the registry for the Python 2.7 install > location and then installs it. I had to manually add c:\python27 and > c:\python27\scripts to my PATH, but that method is clean and easy. Thanks for confirmation. Then we should go with this approach. 1. check mercurial page for python requirements (should be python 2.7) 2. install python on windows 3. install the "Mercurial X.XX for Python X.X on Windows XXX (source install)". 4. adjust path @Rick, please update the CL to use this procedure.
Sign in to reply to this message.
Done, PTAL
Sign in to reply to this message.
https://codereview.appspot.com/7558043/diff/15001/doc/contribute.html File doc/contribute.html (right): https://codereview.appspot.com/7558043/diff/15001/doc/contribute.html#newcode141 doc/contribute.html:141: Windows (source install)" installer from the Mercurial download page. I think we should include a link to http://mercurial.selenic.com/downloads/ so that users don't end up going to http://mercurial.selenic.com/wiki/Download. The latter ranks high on my work computer but low at home in search results for some reason.
Sign in to reply to this message.
Maybe we should just use a Wiki page like minux suggested. Mercurial install instructions are also in doc/install/source. I would think contributors would probably install from source first and wouldn't have the necessary bits for the code review extension on Windows if they followed those instructions.
Sign in to reply to this message.
I think we should just put this on a wiki page, and change this CL to just add a link to that page. I don't want to have to update golang.org every time the Mercurial developers change their mind.
Sign in to reply to this message.
On 2013/03/10 23:35:20, adg wrote: > I think we should just put this on a wiki page, and change this CL to just add a > link to that page. I don't want to have to update http://golang.org every time the > Mercurial developers change their mind. SGTM Can someone create the page for me to link to? Thanks.
Sign in to reply to this message.
On 11 March 2013 11:00, <rickarnoldjr@gmail.com> wrote: > Can someone create the page for me to link to? I just gave you access to the go-wiki project, so you can create the page: https://code.google.com/p/go-wiki/w/edit Please put the text that was originally in this CL to that page. Thanks for your help, Andrew
Sign in to reply to this message.
PTAL
Sign in to reply to this message.
*** Submitted as https://code.google.com/p/go/source/detail?r=3ab94dcee59a *** doc/contribute: add instructions to fix codereview on windows Tell Windows users how to update Mercurial's library.zip to add some missing dependencies. Fixes issue 4745. R=golang-dev, patrick.allen.higgins, minux.ma, adg CC=golang-dev https://codereview.appspot.com/7558043 Committer: Andrew Gerrand <adg@golang.org>
Sign in to reply to this message.
|