Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(880)

Issue 7558043: code review 7558043: doc/contribute: add instructions to fix codereview on w... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by rick
Modified:
11 years ago
Reviewers:
CC:
golang-dev, pah, minux1, adg
Visibility:
Public.

Description

doc/contribute: add instructions to fix codereview on windows Tell Windows users how to update Mercurial's library.zip to add some missing dependencies. Fixes issue 4745.

Patch Set 1 #

Patch Set 2 : diff -r e7e2b3ec4717 https://code.google.com/p/go #

Patch Set 3 : diff -r e7e2b3ec4717 https://code.google.com/p/go #

Patch Set 4 : diff -r e7e2b3ec4717 https://code.google.com/p/go #

Total comments: 1

Patch Set 5 : diff -r e7e2b3ec4717 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M doc/contribute.html View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 16
rick
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
11 years ago (2013-03-07 01:52:53 UTC) #1
pah
LGTM I had to do this two days ago, thanks for documenting it.
11 years ago (2013-03-07 13:20:37 UTC) #2
minux1
I've done this (make codereview working on windows) once. And it seems the exact list ...
11 years ago (2013-03-07 15:35:05 UTC) #3
pah
If installing Python and then installing the Mercurial source packages is takes around the same ...
11 years ago (2013-03-07 16:57:13 UTC) #4
minux1
On Fri, Mar 8, 2013 at 12:57 AM, Patrick Higgins <patrick.allen.higgins@gmail.com> wrote: > If installing ...
11 years ago (2013-03-07 17:09:53 UTC) #5
pah
On Thu, Mar 7, 2013 at 10:09 AM, minux <minux.ma@gmail.com> wrote: > what does the ...
11 years ago (2013-03-07 18:46:41 UTC) #6
minux1
On Fri, Mar 8, 2013 at 2:46 AM, Patrick Higgins <patrick.allen.higgins@gmail.com> wrote: > On Thu, ...
11 years ago (2013-03-07 18:55:39 UTC) #7
rick
Done, PTAL
11 years ago (2013-03-07 23:55:44 UTC) #8
pah
https://codereview.appspot.com/7558043/diff/15001/doc/contribute.html File doc/contribute.html (right): https://codereview.appspot.com/7558043/diff/15001/doc/contribute.html#newcode141 doc/contribute.html:141: Windows (source install)" installer from the Mercurial download page. ...
11 years ago (2013-03-08 02:33:13 UTC) #9
pah
Maybe we should just use a Wiki page like minux suggested. Mercurial install instructions are ...
11 years ago (2013-03-08 02:36:58 UTC) #10
adg
I think we should just put this on a wiki page, and change this CL ...
11 years ago (2013-03-10 23:35:20 UTC) #11
rick
On 2013/03/10 23:35:20, adg wrote: > I think we should just put this on a ...
11 years ago (2013-03-11 00:00:35 UTC) #12
adg
On 11 March 2013 11:00, <rickarnoldjr@gmail.com> wrote: > Can someone create the page for me ...
11 years ago (2013-03-11 00:05:10 UTC) #13
rick
PTAL
11 years ago (2013-03-11 00:54:41 UTC) #14
adg
LGTM
11 years ago (2013-03-11 01:14:05 UTC) #15
adg
11 years ago (2013-03-11 01:15:01 UTC) #16
*** Submitted as https://code.google.com/p/go/source/detail?r=3ab94dcee59a ***

doc/contribute: add instructions to fix codereview on windows

Tell Windows users how to update Mercurial's library.zip to add some missing
dependencies.

Fixes issue 4745.

R=golang-dev, patrick.allen.higgins, minux.ma, adg
CC=golang-dev
https://codereview.appspot.com/7558043

Committer: Andrew Gerrand <adg@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b