Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(87)

Issue 7537043: code review 7537043: go/types: implement constant string(x) conversions (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 7 months ago by gri
Modified:
8 years, 7 months ago
Reviewers:
CC:
adonovan, r, golang-dev
Visibility:
Public.

Description

go/types: implement constant string(x) conversions Fixes issue 4982.

Patch Set 1 #

Total comments: 2

Patch Set 2 : diff -r cb98d0bcf923 https://code.google.com/p/go #

Patch Set 3 : diff -r a688fd4f607d https://code.google.com/p/go #

Patch Set 4 : diff -r a688fd4f607d https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -7 lines) Patch
M src/pkg/go/types/conversions.go View 1 2 chunks +26 lines, -3 lines 0 comments Download
M src/pkg/go/types/operand.go View 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/go/types/testdata/conversions.src View 1 chunk +22 lines, -4 lines 0 comments Download

Messages

Total messages: 5
gri
Hello adonovan (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
8 years, 7 months ago (2013-03-06 21:49:04 UTC) #1
adonovan
On 2013/03/06 21:49:04, gri wrote: > Hello adonovan (cc: mailto:golang-dev@googlegroups.com), > > I'd like you ...
8 years, 7 months ago (2013-03-06 21:56:35 UTC) #2
r
LGTM https://codereview.appspot.com/7537043/diff/1/src/pkg/go/types/conversions.go File src/pkg/go/types/conversions.go (right): https://codereview.appspot.com/7537043/diff/1/src/pkg/go/types/conversions.go#newcode46 src/pkg/go/types/conversions.go:46: x.val = string(codepoint) i doubt it matters in ...
8 years, 7 months ago (2013-03-06 22:02:54 UTC) #3
gri
https://codereview.appspot.com/7537043/diff/1/src/pkg/go/types/conversions.go File src/pkg/go/types/conversions.go (right): https://codereview.appspot.com/7537043/diff/1/src/pkg/go/types/conversions.go#newcode46 src/pkg/go/types/conversions.go:46: x.val = string(codepoint) On 2013/03/06 22:02:54, r wrote: > ...
8 years, 7 months ago (2013-03-07 00:09:47 UTC) #4
gri
8 years, 7 months ago (2013-03-07 00:15:14 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=e7e2b3ec4717 ***

go/types: implement constant string(x) conversions

Fixes issue 4982.

R=adonovan, r
CC=golang-dev
https://codereview.appspot.com/7537043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b