Issue 7537043: code review 7537043: go/types: implement constant string(x) conversions

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7537043: code review 7537043: go/types: implement constant string(x) conversions (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by gri

Modified:
11 years, 1 month ago

Reviewers:

CC:
adonovan, r, golang-dev

Visibility:
Public.

Description

go/types: implement constant string(x) conversions Fixes issue 4982.

Patch Set 2 : diff -r cb98d0bcf923 https://code.google.com/p/go #

Patch Set 3 : diff -r a688fd4f607d https://code.google.com/p/go #

Patch Set 4 : diff -r a688fd4f607d https://code.google.com/p/go #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -7 lines)			Patch
M	src/pkg/go/types/conversions.go	View	1	2 chunks	+26 lines, -3 lines	0 comments	Download
M	src/pkg/go/types/operand.go	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pkg/go/types/testdata/conversions.src	View		1 chunk	+22 lines, -4 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

gri

Hello adonovan (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 1 month ago (2013-03-06 21:49:04 UTC) #1

adonovan

On 2013/03/06 21:49:04, gri wrote: > Hello adonovan (cc: mailto:golang-dev@googlegroups.com), > > I'd like you ...

11 years, 1 month ago (2013-03-06 21:56:35 UTC) #2

LGTM https://codereview.appspot.com/7537043/diff/1/src/pkg/go/types/conversions.go File src/pkg/go/types/conversions.go (right): https://codereview.appspot.com/7537043/diff/1/src/pkg/go/types/conversions.go#newcode46 src/pkg/go/types/conversions.go:46: x.val = string(codepoint) i doubt it matters in ...

11 years, 1 month ago (2013-03-06 22:02:54 UTC) #3

gri

https://codereview.appspot.com/7537043/diff/1/src/pkg/go/types/conversions.go File src/pkg/go/types/conversions.go (right): https://codereview.appspot.com/7537043/diff/1/src/pkg/go/types/conversions.go#newcode46 src/pkg/go/types/conversions.go:46: x.val = string(codepoint) On 2013/03/06 22:02:54, r wrote: > ...

11 years, 1 month ago (2013-03-07 00:09:47 UTC) #4

gri

11 years, 1 month ago (2013-03-07 00:15:14 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=e7e2b3ec4717 ***

go/types: implement constant string(x) conversions

Fixes issue 4982.

R=adonovan, r
CC=golang-dev
https://codereview.appspot.com/7537043

Expand All Messages | Collapse All Messages