Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(285)

Issue 7533044: code review 7533044: exp/norm: delete, part of moving to go.text (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by r
Modified:
12 years, 3 months ago
Reviewers:
albert.strasheim
CC:
golang-dev, rsc
Visibility:
Public.

Description

exp/norm: delete, part of moving to go.text See also https://codereview.appspot.com/7520044

Patch Set 1 #

Patch Set 2 : diff -r 622045a2f25a https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11832 lines) Patch
R src/pkg/exp/norm/Makefile View 1 chunk +0 lines, -30 lines 0 comments Download
R src/pkg/exp/norm/composition.go View 1 chunk +0 lines, -382 lines 0 comments Download
R src/pkg/exp/norm/composition_test.go View 1 chunk +0 lines, -143 lines 0 comments Download
R src/pkg/exp/norm/example_iter_test.go View 1 chunk +0 lines, -81 lines 0 comments Download
R src/pkg/exp/norm/forminfo.go View 1 chunk +0 lines, -229 lines 0 comments Download
R src/pkg/exp/norm/input.go View 1 chunk +0 lines, -105 lines 0 comments Download
R src/pkg/exp/norm/iter.go View 1 chunk +0 lines, -401 lines 0 comments Download
R src/pkg/exp/norm/iter_test.go View 1 chunk +0 lines, -188 lines 0 comments Download
R src/pkg/exp/norm/maketables.go View 1 chunk +0 lines, -923 lines 0 comments Download
R src/pkg/exp/norm/maketesttables.go View 1 chunk +0 lines, -45 lines 0 comments Download
R src/pkg/exp/norm/norm_test.go View 1 chunk +0 lines, -14 lines 0 comments Download
R src/pkg/exp/norm/normalize.go View 1 chunk +0 lines, -478 lines 0 comments Download
R src/pkg/exp/norm/normalize_test.go View 1 chunk +0 lines, -750 lines 0 comments Download
R src/pkg/exp/norm/normregtest.go View 1 chunk +0 lines, -304 lines 0 comments Download
R src/pkg/exp/norm/readwriter.go View 1 chunk +0 lines, -126 lines 0 comments Download
R src/pkg/exp/norm/readwriter_test.go View 1 chunk +0 lines, -68 lines 0 comments Download
R src/pkg/exp/norm/tables.go View 1 chunk +0 lines, -6779 lines 0 comments Download
R src/pkg/exp/norm/trie.go View 1 chunk +0 lines, -232 lines 0 comments Download
R src/pkg/exp/norm/trie_test.go View 1 chunk +0 lines, -152 lines 0 comments Download
R src/pkg/exp/norm/triedata_test.go View 1 chunk +0 lines, -85 lines 0 comments Download
R src/pkg/exp/norm/triegen.go View 1 chunk +0 lines, -317 lines 0 comments Download

Messages

Total messages: 5
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
12 years, 3 months ago (2013-03-06 22:07:06 UTC) #1
rsc
LGTM
12 years, 3 months ago (2013-03-06 22:29:58 UTC) #2
r
*** Submitted as https://code.google.com/p/go/source/detail?r=37d4691df584 *** exp/norm: delete, part of moving to go.text See also https://codereview.appspot.com/7520044 ...
12 years, 3 months ago (2013-03-06 22:34:05 UTC) #3
albert.strasheim
On 2013/03/06 22:34:05, r wrote: > *** Submitted as https://code.google.com/p/go/source/detail?r=37d4691df584 *** > exp/norm: delete, part ...
12 years, 3 months ago (2013-03-07 00:16:52 UTC) #4
r
12 years, 3 months ago (2013-03-07 00:20:33 UTC) #5
I thought I killed that one already. Well spotted.

-rob
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b