Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(146)

Issue 7520044: code review 7520044: go.text/unicode/norm: create from main repo's exp/norm (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by r
Modified:
12 years, 3 months ago
Reviewers:
albert.strasheim
CC:
golang-dev, bradfitz, r
Visibility:
Public.

Description

go.text/unicode/norm: create from main repo's exp/norm See also https://codereview.appspot.com/7533044 Fixes issue 1621.

Patch Set 1 #

Patch Set 2 : diff -r 1749fec1e095 https://code.google.com/p/go.text #

Patch Set 3 : diff -r 1749fec1e095 https://code.google.com/p/go.text #

Patch Set 4 : diff -r 1749fec1e095 https://code.google.com/p/go.text #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11832 lines, -0 lines) Patch
A unicode/norm/Makefile View 1 1 chunk +30 lines, -0 lines 0 comments Download
A unicode/norm/composition.go View 1 1 chunk +382 lines, -0 lines 0 comments Download
A unicode/norm/composition_test.go View 1 1 chunk +143 lines, -0 lines 0 comments Download
A unicode/norm/example_iter_test.go View 1 1 chunk +81 lines, -0 lines 1 comment Download
A unicode/norm/forminfo.go View 1 1 chunk +229 lines, -0 lines 0 comments Download
A unicode/norm/input.go View 1 1 chunk +105 lines, -0 lines 0 comments Download
A unicode/norm/iter.go View 1 1 chunk +401 lines, -0 lines 0 comments Download
A unicode/norm/iter_test.go View 1 1 chunk +188 lines, -0 lines 0 comments Download
A unicode/norm/maketables.go View 1 1 chunk +923 lines, -0 lines 0 comments Download
A unicode/norm/maketesttables.go View 1 1 chunk +45 lines, -0 lines 0 comments Download
A unicode/norm/norm_test.go View 1 1 chunk +14 lines, -0 lines 0 comments Download
A unicode/norm/normalize.go View 1 1 chunk +478 lines, -0 lines 0 comments Download
A unicode/norm/normalize_test.go View 1 1 chunk +750 lines, -0 lines 0 comments Download
A unicode/norm/normregtest.go View 1 1 chunk +304 lines, -0 lines 1 comment Download
A unicode/norm/readwriter.go View 1 1 chunk +126 lines, -0 lines 0 comments Download
A unicode/norm/readwriter_test.go View 1 1 chunk +68 lines, -0 lines 0 comments Download
A unicode/norm/tables.go View 1 1 chunk +6779 lines, -0 lines 0 comments Download
A unicode/norm/trie.go View 1 1 chunk +232 lines, -0 lines 0 comments Download
A unicode/norm/trie_test.go View 1 1 chunk +152 lines, -0 lines 0 comments Download
A unicode/norm/triedata_test.go View 1 1 chunk +85 lines, -0 lines 0 comments Download
A unicode/norm/triegen.go View 1 1 chunk +317 lines, -0 lines 0 comments Download

Messages

Total messages: 4
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.text
12 years, 3 months ago (2013-03-06 22:13:51 UTC) #1
bradfitz
LGTM On Wed, Mar 6, 2013 at 2:13 PM, <r@golang.org> wrote: > Reviewers: golang-dev1, > ...
12 years, 3 months ago (2013-03-06 22:15:05 UTC) #2
r
*** Submitted as https://code.google.com/p/go/source/detail?r=13ae09c7ea11&repo=text *** go.text/unicode/norm: create from main repo's exp/norm See also https://codereview.appspot.com/7533044 Fixes ...
12 years, 3 months ago (2013-03-06 22:15:53 UTC) #3
albert.strasheim
12 years, 3 months ago (2013-03-07 00:26:33 UTC) #4
Message was sent while issue was closed.
two more exp/norm bits...

https://codereview.appspot.com/7520044/diff/7001/unicode/norm/example_iter_te...
File unicode/norm/example_iter_test.go (right):

https://codereview.appspot.com/7520044/diff/7001/unicode/norm/example_iter_te...
unicode/norm/example_iter_test.go:9: "exp/norm"
an old exp/norm reference

https://codereview.appspot.com/7520044/diff/7001/unicode/norm/normregtest.go
File unicode/norm/normregtest.go (right):

https://codereview.appspot.com/7520044/diff/7001/unicode/norm/normregtest.go#...
unicode/norm/normregtest.go:12: "exp/norm"
and another one
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b