Issue 74350044: Fix some issues with Ninja build.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 74350044: Fix some issues with Ninja build. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by etienneb

Modified:
10 years, 1 month ago

Reviewers:
chrisha

CC:
sawbuck-changes_googlegroups.com

Base URL:
http://sawbuck.googlecode.com/svn/trunk/

Visibility:
Public.

Fix some issues with Ninja build. R=chrisha@chromium.org, chrisha Committed: https://code.google.com/p/sawbuck/source/detail?r=2070

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	third_party/pcre/pcre.gyp	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4

etienneb

PTAL. Here is some fix needed to make the Ninja build working. This allows build ...

10 years, 1 month ago (2014-03-12 12:22:32 UTC) #1

etienneb

On 2014/03/12 12:22:32, etienneb wrote: > PTAL. > > Here is some fix needed to ...

10 years, 1 month ago (2014-03-12 14:27:53 UTC) #2

etienneb

10 years, 1 month ago (2014-03-12 14:40:38 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r2070 (presubmit successful).