DescriptionFix GYP rules for MASM to allow Ninja build.
By looking at https://codereview.chromium.org/11738002
file: nss.gyp
they use 'process_outputs_as_sources': 1
I looked at the generated ninja file, the option adds the asm.obj file to the link command-line. Which solve the missing symbols when compiling with ninja:
[35/35] LINK_EMBED core_unittests.exe
FAILED: D:\src\syzygy\src\third_party\python_26\python.exe gyp-win-tool link-with-manifests environment.x86 True core_unittests.exe "D:\src\
syzygy\src\third_party\python_26\python.exe gyp-win-tool link-wrapper environment.x86 False link.exe /nologo /OUT:core_unittests.exe @core_u
nittests.exe.rsp" 1 mt.exe rc.exe "obj\syzygy\core\core_unittests.core_unittests.exe.intermediate.manifest" obj\syzygy\core\core_unittests.c
ore_unittests.exe.generated.manifest
core_unittests.disassembler_unittest.obj : error LNK2019: unresolved external symbol _assembly_func referenced in function "private: virtual
void __thiscall core::DisassemblerTest_DisassembleFull_Test::TestBody(void)" (?TestBody@DisassemblerTest_DisassembleFull_Test@core@@EAEXXZ)
It seems to work with MSVS in both cases.
So, if somebody knows a reason to keep this to '0', please speak now or stay quiet forever.
R=chrisha@chromium.org, rogerm@chromium.org, chrisha, rogerm
BUG=
Committed: https://code.google.com/p/sawbuck/source/detail?r=2071
Patch Set 1 #Patch Set 2 : rebase #
MessagesTotal messages: 4
|