Issue 7399051: code review 7399051: cmd/vet: silence error from type checker unless verbose...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7399051: code review 7399051: cmd/vet: silence error from type checker unless verbose... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by r

Modified:
11 years, 2 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

cmd/vet: silence error from type checker unless verbose is set. Also restores the checking of _test.go files, which disappeared as a result of the package-at-a-time change. Fixes issue 4895.

Patch Set 2 : diff -r 408b088723fd https://code.google.com/p/go #

Total comments: 1

Patch Set 3 : diff -r ebc229da2df9 https://code.google.com/p/go/ #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -9 lines)			Patch
	M	src/cmd/vet/main.go	View	1 2	3 chunks	+22 lines, -9 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 2 months ago (2013-02-25 19:13:59 UTC) #1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

11 years, 2 months ago (2013-02-25 19:34:51 UTC) #2

rsc

LGTM https://codereview.appspot.com/7399051/diff/3001/src/cmd/vet/main.go File src/cmd/vet/main.go (right): https://codereview.appspot.com/7399051/diff/3001/src/cmd/vet/main.go#newcode162 src/cmd/vet/main.go:162: names := append(pkg.GoFiles, pkg.CgoFiles...) Just for my neuroses, ...

11 years, 2 months ago (2013-02-25 22:16:59 UTC) #3

11 years, 2 months ago (2013-02-26 00:29:14 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=fb4e43176b32 ***

cmd/vet: silence error from type checker unless verbose is set.
Also restores the checking of _test.go files, which disappeared
as a result of the package-at-a-time change.
Fixes issue 4895.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/7399051

Expand All Messages | Collapse All Messages