Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(23)

Issue 7399051: code review 7399051: cmd/vet: silence error from type checker unless verbose... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by r
Modified:
7 years, 3 months ago
Reviewers:
CC:
golang-dev, rsc
Visibility:
Public.

Description

cmd/vet: silence error from type checker unless verbose is set. Also restores the checking of _test.go files, which disappeared as a result of the package-at-a-time change. Fixes issue 4895.

Patch Set 1 #

Patch Set 2 : diff -r 408b088723fd https://code.google.com/p/go #

Total comments: 1

Patch Set 3 : diff -r ebc229da2df9 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -9 lines) Patch
M src/cmd/vet/main.go View 1 2 3 chunks +22 lines, -9 lines 0 comments Download

Messages

Total messages: 4
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
7 years, 3 months ago (2013-02-25 19:13:59 UTC) #1
r
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.
7 years, 3 months ago (2013-02-25 19:34:51 UTC) #2
rsc
LGTM https://codereview.appspot.com/7399051/diff/3001/src/cmd/vet/main.go File src/cmd/vet/main.go (right): https://codereview.appspot.com/7399051/diff/3001/src/cmd/vet/main.go#newcode162 src/cmd/vet/main.go:162: names := append(pkg.GoFiles, pkg.CgoFiles...) Just for my neuroses, ...
7 years, 3 months ago (2013-02-25 22:16:59 UTC) #3
r
7 years, 3 months ago (2013-02-26 00:29:14 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=fb4e43176b32 ***

cmd/vet: silence error from type checker unless verbose is set.
Also restores the checking of _test.go files, which disappeared
as a result of the package-at-a-time change.
Fixes issue 4895.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/7399051
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b