Issue 7369056: code review 7369056: net/http: fix a bunch of test leaks

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7369056: code review 7369056: net/http: fix a bunch of test leaks (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by bradfitz

Modified:
12 years ago

Reviewers:

CC:
golang-dev, adg

Visibility:
Public.

Description

net/http: fix a bunch of test leaks And one real leak in TimeoutHandler. Fixes issue 4821

Patch Set 2 : diff -r 6f89256bf255 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 6f89256bf255 https://go.googlecode.com/hg/ #

Total comments: 4

Patch Set 4 : diff -r 1e891021e069 https://go.googlecode.com/hg/ #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+162 lines, -6 lines)			Patch
M	src/pkg/net/http/client_test.go	View	1	20 chunks	+26 lines, -1 line	0 comments	Download
M	src/pkg/net/http/filetransport_test.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pkg/net/http/fs_test.go	View	1	14 chunks	+16 lines, -0 lines	0 comments	Download
M	src/pkg/net/http/serve_test.go	View	1	29 chunks	+32 lines, -2 lines	0 comments	Download
M	src/pkg/net/http/server.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/net/http/transport.go	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
M	src/pkg/net/http/transport_test.go	View	1	24 chunks	+25 lines, -0 lines	0 comments	Download
A	src/pkg/net/http/z_last_test.go	View	1	1 chunk	+60 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years ago (2013-02-27 00:21:10 UTC) #1

adg

LGTM https://codereview.appspot.com/7369056/diff/4001/src/pkg/net/http/z_last_test.go File src/pkg/net/http/z_last_test.go (right): https://codereview.appspot.com/7369056/diff/4001/src/pkg/net/http/z_last_test.go#newcode16 src/pkg/net/http/z_last_test.go:16: // This is in a file named z_last_test.go ...

12 years ago (2013-02-27 00:31:50 UTC) #2

bradfitz

12 years ago (2013-02-27 01:12:54 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=faf5a57def8c ***

net/http: fix a bunch of test leaks

And one real leak in TimeoutHandler.

Fixes issue 4821

R=golang-dev, adg
CC=golang-dev
https://codereview.appspot.com/7369056

https://codereview.appspot.com/7369056/diff/4001/src/pkg/net/http/z_last_test.go
File src/pkg/net/http/z_last_test.go (right):

https://codereview.appspot.com/7369056/diff/4001/src/pkg/net/http/z_last_test...
src/pkg/net/http/z_last_test.go:16: // This is in a file named z_last_test.go so
it sorts at the end.
On 2013/02/27 00:31:50, adg wrote:
> I'm not sure the go tool makes and guarantees about this...

well, if I ever see it not be at the end, we'll adapt somehow, or get it
guaranteed.

Expand All Messages | Collapse All Messages