src/pkg/net/http/transport.go - Issue 7369056: code review 7369056: net/http: fix a bunch of test leaks

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/pkg/net/http/transport.go

Issue 7369056: code review 7369056: net/http: fix a bunch of test leaks (Closed)

Patch Set: diff -r 1e891021e069 https://go.googlecode.com/hg/ Created 12 years ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/pkg/net/http/transport.go

===================================================================

--- a/src/pkg/net/http/transport.go

+++ b/src/pkg/net/http/transport.go

@@ -590,11 +590,11 @@

if err == nil {

resp, err = ReadResponse(pc.br, rc.req)

}

+ hasBody := resp != nil && rc.req.Method != "HEAD" && resp.ContentLength != 0

if err != nil {

pc.close()

} else {

- hasBody := rc.req.Method != "HEAD" && resp.ContentLength != 0

if rc.addedGzip && hasBody && resp.Header.Get("Content-Encoding") == "gzip" {

resp.Header.Del("Content-Encoding")

resp.Header.Del("Content-Length")

@@ -614,7 +614,6 @@

alive = false

}

- hasBody := resp != nil && rc.req.Method != "HEAD" && resp.ContentLength != 0

var waitForBodyRead chan bool

if hasBody {

lastbody = resp.Body

« no previous file with comments | « src/pkg/net/http/server.go ('k') | src/pkg/net/http/transport_test.go » ('j') | no next file with comments »