code review 7368046: net: add benchmarks for network interface identification

net: add benchmarks for network interface identification

Current results on linux/amd64:
BenchmarkInterfaces                      20000             80902 ns/op
BenchmarkInterfaceByIndex                50000             71591 ns/op
BenchmarkInterfaceByName                 20000             79908 ns/op
BenchmarkInterfaceAddrs                   2000            836413 ns/op
BenchmarkInterfacesAndAddrs               5000            605946 ns/op
BenchmarkInterfacesAndMulticastAddrs     10000            169029 ns/op

Update issue 4866.

[mikio, 2013-02-21 14:35:45]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[mikio, 2013-02-21 15:21:24]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2013-02-21 15:55:19]

LGTM

https://codereview.appspot.com/7368046/diff/14001/src/pkg/net/interface_test.go
File src/pkg/net/interface_test.go (right):

https://codereview.appspot.com/7368046/diff/14001/src/pkg/net/interface_test....
src/pkg/net/interface_test.go:13: // tests.
, or nil.

https://codereview.appspot.com/7368046/diff/14001/src/pkg/net/interface_test....
src/pkg/net/interface_test.go:132: return
b.Skipf? Oh, we can't skip on a *testing.B, I guess. I thought it was in
*common.

At least Log (or Error)? here and 3 places below too?

[mikio, 2013-02-21 16:19:11]

*** Submitted as https://code.google.com/p/go/source/detail?r=e14ccb3e4514 ***

net: add benchmarks for network interface identification

Current results on linux/amd64:
BenchmarkInterfaces                      20000             80902 ns/op
BenchmarkInterfaceByIndex                50000             71591 ns/op
BenchmarkInterfaceByName                 20000             79908 ns/op
BenchmarkInterfaceAddrs                   2000            836413 ns/op
BenchmarkInterfacesAndAddrs               5000            605946 ns/op
BenchmarkInterfacesAndMulticastAddrs     10000            169029 ns/op

Update issue 4866.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/7368046

[mikio, 2013-02-21 17:04:49]

>
https://codereview.appspot.com/7368046/diff/14001/src/pkg/net/interface_test....
> src/pkg/net/interface_test.go:13: // tests.
> , or nil.
>
>
https://codereview.appspot.com/7368046/diff/14001/src/pkg/net/interface_test....
> src/pkg/net/interface_test.go:132: return
> b.Skipf? Oh, we can't skip on a *testing.B, I guess. I thought it was in
> *common.
>
> At least Log (or Error)? here and 3 places below too?

oops, i missed; will address in CL 7384048, thanks.

[dave_cheney.net, 2013-02-21 20:15:35]

> src/pkg/net/interface_test.go:132: return
> b.Skipf? Oh, we can't skip on a *testing.B, I guess. I thought it was in
> *common.
>
> At least Log (or Error)? here and 3 places below too?

I will look at this today, or at least raise an issue

[dave_cheney.net, 2013-02-22 10:46:52]

https://codereview.appspot.com/7379046

On Fri, Feb 22, 2013 at 7:15 AM, Dave Cheney <dave@cheney.net> wrote:
>> src/pkg/net/interface_test.go:132: return
>> b.Skipf? Oh, we can't skip on a *testing.B, I guess. I thought it was in
>> *common.
>>
>> At least Log (or Error)? here and 3 places below too?
>
> I will look at this today, or at least raise an issue