Issue 7379046: code review 7379046: testing: move Skip into *common

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7379046: code review 7379046: testing: move Skip into *common (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by dave

Modified:
12 years, 3 months ago

Reviewers:

CC:
golang-dev, gpaul, rsc

Visibility:
Public.

Description

testing: move Skip into *common Move Skip and friends into *common so benchmarks can also be skipped.

Patch Set 2 : diff -r ca83aeaa55e0 https://code.google.com/p/go #

Patch Set 3 : diff -r ca83aeaa55e0 https://code.google.com/p/go #

Total comments: 2

Patch Set 4 : diff -r 6ba97196100a https://code.google.com/p/go #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -40 lines)			Patch
	M	src/pkg/testing/testing.go	View	1 2 3	5 chunks	+40 lines, -40 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dave_cheney.net

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

12 years, 3 months ago (2013-02-22 11:04:43 UTC) #1

gpaul

LGTM https://codereview.appspot.com/7379046/diff/5001/src/pkg/testing/testing.go File src/pkg/testing/testing.go (right): https://codereview.appspot.com/7379046/diff/5001/src/pkg/testing/testing.go#newcode13 src/pkg/testing/testing.go:13: // Tests may be skipped if not applicable ...

12 years, 3 months ago (2013-02-22 11:58:31 UTC) #2

dave_cheney.net

12 years, 3 months ago (2013-02-23 00:58:10 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=82796ae901bb ***

testing: move Skip into *common

Move Skip and friends into *common so benchmarks can also be skipped.

R=golang-dev, gustav.paul, rsc
CC=golang-dev
https://codereview.appspot.com/7379046

https://codereview.appspot.com/7379046/diff/5001/src/pkg/testing/testing.go
File src/pkg/testing/testing.go (right):

https://codereview.appspot.com/7379046/diff/5001/src/pkg/testing/testing.go#n...
src/pkg/testing/testing.go:13: // Tests may be skipped if not applicable like
this:
On 2013/02/22 11:58:31, gpaul wrote:
> // Tests and benchmarks may be skipped ..?

Done.

Expand All Messages | Collapse All Messages