code review 7319050: runtime/debug: make TestFreeOSMemory repeatable

runtime/debug: make TestFreeOSMemory repeatable
Fixes issue 4835.

[dvyukov, 2013-02-18 11:39:43]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://dvyukov%40google.com@code.google.com/p/go/

[albert.strasheim, 2013-02-18 11:42:48]

LGTM.

Fixes issue 4835.

[dvyukov, 2013-02-18 11:46:26]

On 2013/02/18 11:42:48, albert.strasheim wrote:
> LGTM.
> 
> Fixes issue 4835.

Done.

[dvyukov, 2013-02-18 11:46:55]

*** Submitted as https://code.google.com/p/go/source/detail?r=bfaaa2075564 ***

runtime/debug: make TestFreeOSMemory repeatable
Fixes issue 4835.

R=golang-dev, fullung
CC=golang-dev
https://codereview.appspot.com/7319050

[albert.strasheim, 2013-02-19 03:36:03]

Hello

I clearly didn't test this properly. It now fails with:

--- FAIL: TestFreeOSMemory-89 (0.00 seconds)
garbage_test.go:86: released before=0; released after=0; did not go up
FAIL

Regards

Albert

[rsc, 2013-02-19 16:32:52]

It always works the first time, right? I suggest moving the allocation back to
the global (it is there so that there cannot be any trace of the allocation
lying around on the test goroutine stack) and then just make the test do:

if big == nil {
    return
}

so that subsequent tests do not repeat the test.

[dvyukov, 2013-02-20 08:15:56]

mailed https://codereview.appspot.com/7379043



On Tue, Feb 19, 2013 at 8:32 PM, <rsc@golang.org> wrote:

> It always works the first time, right? I suggest moving the allocation
> back to the global (it is there so that there cannot be any trace of the
> allocation lying around on the test goroutine stack) and then just make
> the test do:
>
> if big == nil {
>     return
> }
>
> so that subsequent tests do not repeat the test.
>
>
>
https://codereview.appspot.**com/7319050/<https://codereview.appspot.com/7319...
>