Issue 7379043: code review 7379043: runtime/debug: deflake TestFreeOSMemory

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7379043: code review 7379043: runtime/debug: deflake TestFreeOSMemory (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by dvyukov

Modified:
12 years ago

Reviewers:

CC:
golang-dev, dave_cheney.net

Visibility:
Public.

Description

runtime/debug: deflake TestFreeOSMemory This is followup to https://codereview.appspot.com/7319050/

Patch Set 2 : diff -r 28d951917340 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 28d951917340 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 833cfd94e6dd https://dvyukov%40google.com@code.google.com/p/go/ #

Total comments: 2

Patch Set 5 : diff -r 833cfd94e6dd https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 6 : diff -r 833cfd94e6dd https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	src/pkg/runtime/debug/garbage_test.go	View	1 2 3 4	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

12 years ago (2013-02-20 08:15:30 UTC) #1

dave_cheney.net

LGTM. Thank you. https://codereview.appspot.com/7379043/diff/9001/src/pkg/runtime/debug/garbage_test.go File src/pkg/runtime/debug/garbage_test.go (right): https://codereview.appspot.com/7379043/diff/9001/src/pkg/runtime/debug/garbage_test.go#newcode79 src/pkg/runtime/debug/garbage_test.go:79: return t.Skip("test is not reliable when ...

12 years ago (2013-02-20 08:18:52 UTC) #2

dvyukov

https://codereview.appspot.com/7379043/diff/9001/src/pkg/runtime/debug/garbage_test.go File src/pkg/runtime/debug/garbage_test.go (right): https://codereview.appspot.com/7379043/diff/9001/src/pkg/runtime/debug/garbage_test.go#newcode79 src/pkg/runtime/debug/garbage_test.go:79: return On 2013/02/20 08:18:52, dfc wrote: > t.Skip("test is ...

12 years ago (2013-02-20 08:33:55 UTC) #3

dvyukov

12 years ago (2013-02-20 08:34:22 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=dd18b993ba95 ***

runtime/debug: deflake TestFreeOSMemory
This is followup to https://codereview.appspot.com/7319050/

R=golang-dev, dave
CC=golang-dev
https://codereview.appspot.com/7379043

Expand All Messages | Collapse All Messages