Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(404)

Issue 7319045: code review 7319045: go.crypto/{curve25519,poly1305,salsa20/salsa}: add //go... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 9 months ago by minux1
Modified:
6 years, 8 months ago
Reviewers:
CC:
golang-dev, rsc, agl1
Visibility:
Public.

Description

go.crypto/{curve25519,poly1305,salsa20/salsa}: add //go:noescape annotation

Patch Set 1 #

Patch Set 2 : diff -r 75e869cbf335 https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r 75e869cbf335 https://code.google.com/p/go.crypto #

Patch Set 4 : diff -r 75e869cbf335 https://code.google.com/p/go.crypto #

Patch Set 5 : diff -r 75e869cbf335 https://code.google.com/p/go.crypto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M curve25519/mont25519_amd64.go View 1 2 3 1 chunk +15 lines, -0 lines 0 comments Download
M poly1305/sum_amd64.go View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M salsa20/salsa/salsa20_amd64.go View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4
minux1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto
6 years, 9 months ago (2013-02-14 08:38:39 UTC) #1
rsc
LGTM but please make them not be doc comments. //go:noescape func cswap(...)
6 years, 9 months ago (2013-02-14 15:20:08 UTC) #2
agl1
LGTM with Russ's suggestion.
6 years, 9 months ago (2013-02-14 16:25:45 UTC) #3
minux1
6 years, 8 months ago (2013-02-19 11:15:14 UTC) #4
*** Submitted as
https://code.google.com/p/go/source/detail?r=5338b7932892&repo=crypto ***

go.crypto/{curve25519,poly1305,salsa20/salsa}: add //go:noescape annotation

R=golang-dev, rsc, agl
CC=golang-dev
https://codereview.appspot.com/7319045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b