Issue 7319045: code review 7319045: go.crypto/{curve25519,poly1305,salsa20/salsa}: add //go...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7319045: code review 7319045: go.crypto/{curve25519,poly1305,salsa20/salsa}: add //go... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by minux1

Modified:
11 years, 2 months ago

Reviewers:

CC:
golang-dev, rsc, agl1

Visibility:
Public.

Description

go.crypto/{curve25519,poly1305,salsa20/salsa}: add //go:noescape annotation

Patch Set 1 #

Patch Set 2 : diff -r 75e869cbf335 https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r 75e869cbf335 https://code.google.com/p/go.crypto #

Patch Set 4 : diff -r 75e869cbf335 https://code.google.com/p/go.crypto #

Patch Set 5 : diff -r 75e869cbf335 https://code.google.com/p/go.crypto #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -0 lines)			Patch
M	curve25519/mont25519_amd64.go	View	1 2 3	1 chunk	+15 lines, -0 lines	0 comments	Download
M	poly1305/sum_amd64.go	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download
M	salsa20/salsa/salsa20_amd64.go	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto

11 years, 2 months ago (2013-02-14 08:38:39 UTC) #1

rsc

LGTM but please make them not be doc comments. //go:noescape func cswap(...)

11 years, 2 months ago (2013-02-14 15:20:08 UTC) #2

minux1

11 years, 2 months ago (2013-02-19 11:15:14 UTC) #4

*** Submitted as
https://code.google.com/p/go/source/detail?r=5338b7932892&repo=crypto ***

go.crypto/{curve25519,poly1305,salsa20/salsa}: add //go:noescape annotation

R=golang-dev, rsc, agl
CC=golang-dev
https://codereview.appspot.com/7319045

Expand All Messages | Collapse All Messages