Issue 7309063: code review 7309063: io: fix CopyN EOF behavior, and adds a new CopyN test.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7309063: code review 7309063: io: fix CopyN EOF behavior, and adds a new CopyN test. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by bradfitz

Modified:
13 years, 5 months ago

Reviewers:
rsc, golang-dev

Visibility:
Public.

Description

io: fix CopyN EOF behavior, and adds a new CopyN test. I'm not sure whether this is gross or not. Arguably, sendfile in pkg net already had knowledge of io.CopyN and its LimitedReader before. This keeps that knowledge, but changes it slightly. This CL doesn't update any OS other than Linux yet.

Patch Set 1 #

Patch Set 2 : diff -r 6094e6f45477 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 6094e6f45477 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 6094e6f45477 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 6094e6f45477 https://go.googlecode.com/hg/ #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -3 lines)			Patch
M	src/pkg/io/io.go	View	1 2 3	1 chunk	+20 lines, -3 lines	0 comments	Download
M	src/pkg/io/io_test.go	View	1	2 chunks	+11 lines, -0 lines	0 comments	Download
M	src/pkg/net/sendfile_linux.go	View	1 2 3	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 6 months ago (2013-02-08 16:31:00 UTC) #1

rsc

Counter-argument: leave new behavior alone and document, like we did for io.ReadFull.

13 years, 6 months ago (2013-02-08 17:14:49 UTC) #2

bradfitz

Great, that's my preference too. Actually depending on how I squint, it looks like the ...

13 years, 6 months ago (2013-02-08 17:20:16 UTC) #3

bradfitz

13 years, 6 months ago (2013-02-09 01:30:21 UTC) #4

Doc proposal: https://codereview.appspot.com/7314069

On Fri, Feb 8, 2013 at 9:20 AM, Brad Fitzpatrick <bradfitz@golang.org>wrote:

> Great, that's my preference too.
>
> Actually depending on how I squint, it looks like the new behavior even
> still could fit the old docs.
>
> It could be more clear, though.  I'll do that later, if nobody beats me to
> it.
>
>
> On Fri, Feb 8, 2013 at 9:14 AM, Russ Cox <rsc@golang.org> wrote:
>
>> Counter-argument: leave new behavior alone and document, like we did for
>> io.ReadFull.
>>
>>
>

Expand All Messages | Collapse All Messages