Issue 7314069: code review 7314069: io: document and test new CopyN return behavior

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7314069: code review 7314069: io: document and test new CopyN return behavior (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by bradfitz

Modified:
12 years, 4 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

io: document and test new CopyN return behavior Changed accidentally in 28966b7b2f0c (CopyN using Copy). Updating docs to be consistent with 29bf5ff5064e (ReadFull & ReadAtLeast)

Patch Set 1 #

Patch Set 2 : diff -r bad13530d9b3 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r bad13530d9b3 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 8a2acfab818c https://go.googlecode.com/hg/ #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -3 lines)			Patch
	M	src/pkg/io/io.go	View	1	1 chunk	+5 lines, -3 lines	0 comments	Download
	M	src/pkg/io/io_test.go	View	1	3 chunks	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 4 months ago (2013-02-09 01:32:22 UTC) #1

bradfitz

12 years, 4 months ago (2013-02-13 21:52:03 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=7dd660609da5 ***

io: document and test new CopyN return behavior

Changed accidentally in 28966b7b2f0c (CopyN using Copy).
Updating docs to be consistent with 29bf5ff5064e (ReadFull & ReadAtLeast)

R=rsc
CC=golang-dev
https://codereview.appspot.com/7314069

Expand All Messages | Collapse All Messages