code review 72780043: runtime: small Native Client fixes

runtime: small Native Client fixes

mem_nacl.c: add SysFault
env_posix.c: add nacl to build tag, from CL 15790043

[dave_cheney.net, 2014-03-09 02:19:43]

Hello rsc@golang.org, remyoudompheng@gmail.com (cc:
golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[dave_cheney.net, 2014-03-09 02:26:23]

With the prereq CLs (mention in the description) and this CL applied env
GOOS=nacl GOARCH=amd64p32 ./make.bash passes.

There is one outstanding warning

# Building packages and commands for nacl/amd64p32.
runtime
# runtime
unaligned stack size 12

Ian's comment on CL 72790043 is probably a hint to what is wrong, but I'm not
sure how to fix it just yet.

[remyoudompheng, 2014-03-09 09:00:24]

On 2014/03/09 02:26:23, dfc wrote:
> With the prereq CLs (mention in the description) and this CL applied env
> GOOS=nacl GOARCH=amd64p32 ./make.bash passes.
> 
> There is one outstanding warning
> 
> # Building packages and commands for nacl/amd64p32.
> runtime
> # runtime
> unaligned stack size 12
> 
> Ian's comment on CL 72790043 is probably a hint to what is wrong, but I'm not
> sure how to fix it just yet.

It's because of an ill-defined stack size (not a multiple of 8).

pkg/runtime/asm_amd64p32.s:TEXT runtime·cgocallback(SB),NOSPLIT,$12-12

see https://codereview.appspot.com/73160043

[remyoudompheng, 2014-03-09 09:28:26]

LGTM

but it is not really true that it "Requires CL 72790043, 73110043"

[dave_cheney.net, 2014-03-09 09:50:48]

That is true, but the build won't be close to passing without them. I'll remove
the line. 

> On 9 Mar 2014, at 20:28, remyoudompheng@gmail.com wrote:
> 
> LGTM
> 
> but it is not really true that it "Requires CL 72790043, 73110043"
> 
> https://codereview.appspot.com/72780043/

[dave_cheney.net, 2014-03-09 22:47:56]

Hello rsc@golang.org, remyoudompheng@gmail.com (cc:
golang-codereviews@googlegroups.com),

Please take another look.

[iant, 2014-03-10 16:52:08]

LGTM

[dave_cheney.net, 2014-03-10 19:58:18]

*** Submitted as https://code.google.com/p/go/source/detail?r=474703cfa0a7 ***

runtime: small Native Client fixes

mem_nacl.c: add SysFault
env_posix.c: add nacl to build tag, from CL 15790043

LGTM=remyoudompheng, iant
R=rsc, remyoudompheng, iant
CC=golang-codereviews
https://codereview.appspot.com/72780043