Issue 73160043: code review 73160043: runtime: fix cgocallback stack size on amd64p32.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 73160043: code review 73160043: runtime: fix cgocallback stack size on amd64p32. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by remyoudompheng

Modified:
10 years, 1 month ago

Reviewers:
dave

CC:
rsc, dave_cheney.net, iant, golang-codereviews

Visibility:
Public.

Description

runtime: fix cgocallback stack size on amd64p32.

Patch Set 1 #

Patch Set 2 : diff -r 1849f83423ca https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 1849f83423ca https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r b2015fbc8fd3 https://go.googlecode.com/hg/ #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/runtime/asm_amd64p32.s	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

remyoudompheng

Hello rsc@golang.org, dave@cheney.net, iant@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

10 years, 2 months ago (2014-03-09 09:00:08 UTC) #1

remyoudompheng

10 years, 2 months ago (2014-03-10 06:58:04 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=e3ff5d42017d ***

runtime: fix cgocallback stack size on amd64p32.

LGTM=dave
R=rsc, dave, iant
CC=golang-codereviews
https://codereview.appspot.com/73160043

Expand All Messages | Collapse All Messages