Issue 7239045: code review 7239045: reflect: Add comment that Value.Slice cannot be called ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7239045: code review 7239045: reflect: Add comment that Value.Slice cannot be called ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by kortschak

Modified:
11 years, 11 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

reflect: Add comment that Value.Slice cannot be called on an unaddressable array. Fixes issue 4736.

Patch Set 2 : diff -r b3af92ac5a0c https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 3 : diff -r 8d4bd93dcd41 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 8d4bd93dcd41 https://go.googlecode.com/hg/ #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/reflect/value.go	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

https://codereview.appspot.com/7239045/diff/2001/src/pkg/reflect/value.go File src/pkg/reflect/value.go (right): https://codereview.appspot.com/7239045/diff/2001/src/pkg/reflect/value.go#newcode1451 src/pkg/reflect/value.go:1451: // It panics if v's Kind is not Array, ...

12 years, 1 month ago (2013-01-31 22:37:09 UTC) #1

kortschak

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 1 month ago (2013-02-01 08:41:06 UTC) #2

rsc

12 years, 1 month ago (2013-02-01 18:03:24 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=40b8e9cc78f8 ***

reflect: document that Value.Slice panics on an unaddressable array.

Fixes issue 4736.

R=rsc
CC=golang-dev
https://codereview.appspot.com/7239045

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages