code review 7239045: reflect: Add comment that Value.Slice cannot be called ...

src/pkg/reflect/value.go

 // Copyright 2009 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 package reflect
 
 import (
         "math"
         "runtime"
         "strconv"
@@ skipping 1430 matching lines @@
 
 // SetString sets v's underlying value to x.
 // It panics if v's Kind is not String or if CanSet() is false.
 func (v Value) SetString(x string) {
         v.mustBeAssignable()
         v.mustBe(String)
         *(*string)(v.val) = x
 }
 
 // Slice returns a slice of v.
-// It panics if v's Kind is not Array, Slice or String, or the array is not addressable.

[rsc, 2013/01/31 22:37:09]

or if v is a non-addressable array.

+// It panics if v's Kind is not Array, Slice or String, or if v is a non-addressable array.
 func (v Value) Slice(beg, end int) Value {
         var (
                 cap  int
                 typ  *sliceType
                 base unsafe.Pointer
         )
         switch k := v.kind(); k {
         default:
                 panic(&ValueError{"reflect.Value.Slice", k})
 
@@ skipping 897 matching lines @@
 func escapes(x interface{}) {
         if dummy.b {
                 dummy.x = x
         }
 }
 
 var dummy struct {
         b bool
         x interface{}
 }