Issue 7231074: http issue 140: jarjar guava & change scope to test/provided

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7231074: http issue 140: jarjar guava & change scope to test/provided (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by yanivi

Modified:
11 years, 2 months ago

Reviewers:
ngmiceli

CC:
rmistry, peleyal

Base URL:
https://code.google.com/p/google-http-java-client/

Visibility:
Public.

http issue 140: jarjar guava & change scope to test/provided http://code.google.com/p/google-http-java-client/issues/detail?id=140

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -47 lines)			Patch
M	google-http-client-gson/pom.xml	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	google-http-client-jackson/pom.xml	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	google-http-client-jackson2/pom.xml	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	google-http-client-test/pom.xml	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	google-http-client/pom.xml	View	4 5	3 chunks	+7 lines, -1 line	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/json/JsonObjectParser.java	View	1	5 chunks	+6 lines, -4 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/util/Lists.java	View	1	3 chunks	+3 lines, -21 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/util/Maps.java	View	1	2 chunks	+5 lines, -6 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/util/Sets.java	View	1	3 chunks	+3 lines, -14 lines	0 comments	Download
M	pom.xml	View	1 2 3 4 5 6	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6

ngmiceli

Looks good, but waiting on https://codereview.appspot.com/7225058/ to test it

11 years, 3 months ago (2013-02-05 15:13:31 UTC) #2

ngmiceli

Need to add a dependency on com.google.guava to google-http-client-appengine/pom.xml

11 years, 2 months ago (2013-02-06 15:41:30 UTC) #4

yanivi

On 2013/02/06 15:41:30, ngmiceli wrote: > Need to add a dependency on com.google.guava to > ...

11 years, 2 months ago (2013-02-06 16:22:56 UTC) #5

My bad, confusion with maven.
LGTM