Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2873)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 7225058: http issue 140: eliminate use of Guava's UnsignedLong & UnsignedInteger (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by yanivi
Modified:
11 years, 3 months ago
Reviewers:
ngmiceli, peleyal
CC:
rmistry
Base URL:
https://code.google.com/p/google-http-java-client/
Visibility:
Public.

Description

http issue 140: eliminate use of Guava's UnsignedLong & UnsignedInteger http://code.google.com/p/google-http-java-client/issues/detail?id=140

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -219 lines) Patch
M clirr-ignored-differences.xml View 1 chunk +60 lines, -0 lines 0 comments Download
M google-http-client-android/src/main/java/com/google/api/client/extensions/android/json/AndroidJsonGenerator.java View 2 chunks +0 lines, -12 lines 0 comments Download
M google-http-client-android/src/main/java/com/google/api/client/extensions/android/json/AndroidJsonParser.java View 1 2 chunks +0 lines, -14 lines 0 comments Download
M google-http-client-gson/src/main/java/com/google/api/client/json/gson/GsonGenerator.java View 2 chunks +0 lines, -12 lines 0 comments Download
M google-http-client-gson/src/main/java/com/google/api/client/json/gson/GsonParser.java View 1 2 chunks +0 lines, -14 lines 0 comments Download
M google-http-client-jackson/src/main/java/com/google/api/client/json/jackson/JacksonGenerator.java View 2 chunks +0 lines, -12 lines 0 comments Download
M google-http-client-jackson/src/main/java/com/google/api/client/json/jackson/JacksonParser.java View 2 chunks +0 lines, -12 lines 0 comments Download
M google-http-client-jackson2/src/main/java/com/google/api/client/json/jackson2/JacksonGenerator.java View 2 chunks +0 lines, -12 lines 0 comments Download
M google-http-client-jackson2/src/main/java/com/google/api/client/json/jackson2/JacksonParser.java View 2 chunks +0 lines, -12 lines 0 comments Download
M google-http-client-test/src/main/java/com/google/api/client/testing/json/AbstractJsonFactoryTest.java View 1 2 5 chunks +2 lines, -15 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/json/JsonGenerator.java View 1 4 chunks +6 lines, -20 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/json/JsonParser.java View 1 4 chunks +6 lines, -22 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/testing/http/json/MockJsonGenerator.java View 2 chunks +0 lines, -10 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/testing/http/json/MockJsonParser.java View 2 chunks +0 lines, -12 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/util/Data.java View 1 8 chunks +26 lines, -23 lines 0 comments Download
M google-http-client/src/test/java/com/google/api/client/util/DataTest.java View 1 2 6 chunks +0 lines, -17 lines 0 comments Download

Messages

Total messages: 5
yanivi
11 years, 3 months ago (2013-01-29 01:46:36 UTC) #1
peleyal
On 2013/01/29 01:46:36, yanivi wrote: LGTM
11 years, 3 months ago (2013-01-29 21:47:43 UTC) #2
yanivi
FYI I won't submit this until https://code.google.com/p/google-api-java-client/issues/detail?id=712 is fixed first.
11 years, 3 months ago (2013-01-29 22:56:36 UTC) #3
yanivi
11 years, 3 months ago (2013-02-01 00:37:59 UTC) #4
ngmiceli
11 years, 3 months ago (2013-02-04 22:34:22 UTC) #5 
On 2013/02/01 00:37:59, yanivi wrote:

Please update once more :)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b