Issue 72010043: code review 72010043: cmd/cc, cmd/5c, cmd/6c, cmd/8c: introduce linkarchinit ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 72010043: code review 72010043: cmd/cc, cmd/5c, cmd/6c, cmd/8c: introduce linkarchinit ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by dave

Modified:
11 years, 3 months ago

Reviewers:
gobot, rsc

CC:
rsc, golang-codereviews

Visibility:
Public.

Description

cmd/cc, cmd/5c, cmd/6c, cmd/8c: introduce linkarchinit and add amd64p32 support Replaces CL 70000043. Introduce linkarchinit() from cmd/ld. For cmd/6c, switch to the amd64p32 linker model if we are building under nacl/amd64p32.

Patch Set 1 #

Patch Set 2 : diff -r 32f0dc88f804 https://code.google.com/p/go #

Patch Set 3 : diff -r 32f0dc88f804 https://code.google.com/p/go #

Patch Set 4 : diff -r 32f0dc88f804 https://code.google.com/p/go #

Patch Set 5 : diff -r 4784aeee8b4a https://code.google.com/p/go #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -4 lines)			Patch
M	src/cmd/6c/txt.c	View	1 2 3	1 chunk	+9 lines, -2 lines	0 comments	Download
M	src/cmd/8c/txt.c	View	1	1 chunk	+7 lines, -1 line	0 comments	Download
M	src/cmd/cc/cc.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/cc/lex.c	View	1 2	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dave_cheney.net

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 3 months ago (2014-03-06 10:40:05 UTC) #1

dave_cheney.net

*** Submitted as https://code.google.com/p/go/source/detail?r=e24ed5c8cecd *** cmd/cc, cmd/5c, cmd/6c, cmd/8c: introduce linkarchinit and add amd64p32 support ...

11 years, 3 months ago (2014-03-06 22:57:23 UTC) #3

gobot

This CL appears to have broken the linux-arm-cheney-panda builder.

11 years, 3 months ago (2014-03-06 23:10:31 UTC) #4

dave_cheney.net

11 years, 3 months ago (2014-03-06 23:11:46 UTC) #5

This was my mistake, cmd/5c/txt.c belonged to another CL so was not
included in the commit.

Fix is here, https://codereview.appspot.com/72220043

On Fri, Mar 7, 2014 at 10:10 AM, <gobot@golang.org> wrote:

> This CL appears to have broken the linux-arm-cheney-panda builder.
>
> https://codereview.appspot.com/72010043/
>

Expand All Messages | Collapse All Messages