code review 72220043: cmd/5c: fix arm build

cmd/5c: fix arm build

cmd/5c/txt.c was missing from CL 72010043.

[dave_cheney.net, 2014-03-06 23:10:58]

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2014-03-06 23:12:28]

LGTM
 On Mar 6, 2014 3:11 PM, <dave@cheney.net> wrote:

> Reviewers: rsc,
>
> Message:
> Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> cmd/5c: fix arm build
>
> cmd/5c/txt.c was missing from CL 72010043.
>
> Please review this at https://codereview.appspot.com/72220043/
>
> Affected files (+7, -1 lines):
>   M src/cmd/5c/txt.c
>
>
> Index: src/cmd/5c/txt.c
> ===================================================================
> --- a/src/cmd/5c/txt.c
> +++ b/src/cmd/5c/txt.c
> @@ -31,11 +31,17 @@
>
>  #include "gc.h"
>
> -LinkArch       *thelinkarch = &linkarm;
>
>  int thechar = '5';
>  char *thestring = "arm";
>
> +LinkArch       *thelinkarch = &linkarm;
> +
> +void
> +linkarchinit(void)
> +{
> +}
> +
>  void
>  ginit(void)
>  {
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[dave_cheney.net, 2014-03-06 23:13:13]

*** Submitted as https://code.google.com/p/go/source/detail?r=7cb38c8ff249 ***

cmd/5c: fix arm build

cmd/5c/txt.c was missing from CL 72010043.

LGTM=bradfitz
R=rsc, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/72220043

[gobot, 2014-03-06 23:35:26]

This CL appears to have broken the darwin-386-cheney builder.

[dave_cheney.net, 2014-03-06 23:37:52]

I believe this is an unrelated failure,

# ../test
# go run run.go -- index2.go

tmp__.go:2431: missing error "index|overflow|truncated|must be integer"
Unmatched Errors:
tmp__.go:2431: invalid slice index cni32 (index must be non-negative)

FAIL	index2.go	27.144s
exit status 1



On Fri, Mar 7, 2014 at 10:35 AM, <gobot@golang.org> wrote:

> This CL appears to have broken the darwin-386-cheney builder.
>
> https://codereview.appspot.com/72220043/
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[rsc, 2014-03-06 23:56:15]

On Thu, Mar 6, 2014 at 6:37 PM, Dave Cheney <dave@cheney.net> wrote:

> I believe this is an unrelated failure,
>
> # ../test
> # go run run.go -- index2.go
>
> tmp__.go:2431: missing error "index|overflow|truncated|must be integer"
> Unmatched Errors:
> tmp__.go:2431: invalid slice index cni32 (index must be non-negative)
>
> FAIL	index2.go	27.144s
> exit status 1
>
>
Yes, that is issue 7344. I have been trying to track it down for the past
two days. No luck yet.

Russ