Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(22)

Issue 70990044: code review 70990044: net/http Request ParseForm method to support PATC...

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 1 month ago by mattetti
Modified:
6 years, 1 month ago
Reviewers:
gobot, bradfitz
CC:
golang-codereviews, bradfitz
Visibility:
Public.

Description

net/http: make Request.ParseForm parse form-urlencoded for method PATCH too Fixes issue 7454

Patch Set 1 #

Patch Set 2 : diff -r 00af00afbace https://code.google.com/p/go #

Patch Set 3 : diff -r 00af00afbace https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -1 line) Patch
M src/pkg/net/http/request.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/net/http/request_test.go View 1 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 9
mattetti
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
6 years, 1 month ago (2014-03-04 07:31:11 UTC) #1
bradfitz
CL description should start with "net/http: " then a short summary line (max ~76 char), ...
6 years, 1 month ago (2014-03-04 16:39:09 UTC) #2
bradfitz
(run `hg change 70990044` to change it)
6 years, 1 month ago (2014-03-04 16:39:26 UTC) #3
mattetti
On 2014/03/04 16:39:26, bradfitz wrote: > (run `hg change 70990044` to change it) updated, thanks ...
6 years, 1 month ago (2014-03-04 17:37:50 UTC) #4
bradfitz
The summary should start with a verb generally. And a period between Request and ParseForm. ...
6 years, 1 month ago (2014-03-04 18:07:20 UTC) #5
mattetti
On 2014/03/04 18:07:20, bradfitz wrote: > The summary should start with a verb generally. And ...
6 years, 1 month ago (2014-03-04 18:25:45 UTC) #6
bradfitz
LGTM
6 years, 1 month ago (2014-03-04 19:56:10 UTC) #7
bradfitz
*** Submitted as https://code.google.com/p/go/source/detail?r=6102786b4487 *** net/http: make Request.ParseForm parse form-urlencoded for method PATCH too Fixes ...
6 years, 1 month ago (2014-03-04 19:58:26 UTC) #8
gobot
6 years, 1 month ago (2014-03-04 21:29:07 UTC) #9
This CL appears to have broken the darwin-amd64-race-cheney builder.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b