Code review - Issue 70990044: code review 70990044: net/http Request ParseForm method to support PATC...https://codereview.appspot.com/2014-03-04T21:29:07+00:00rietveld
Message from unknown
2014-03-04T07:28:35+00:00mattettiurn:md5:19220e421aa861aadddc81c7288a741d
Message from unknown
2014-03-04T07:28:39+00:00mattettiurn:md5:f2c0d920d8bd70b4e54077f24ca2f694
Message from unknown
2014-03-04T07:31:05+00:00mattettiurn:md5:aa7c3796f3590f4aa5881aef89dfdde1
Message from mattAimonetti@gmail.com
2014-03-04T07:31:11+00:00mattettiurn:md5:0c30af1bfe5759fb0125e171ae023d40
Hello golang-codereviews@googlegroups.com,
I'd like you to review this change to
https://code.google.com/p/go
Message from bradfitz@golang.org
2014-03-04T16:39:09+00:00bradfitzurn:md5:358168f576ebd361d8f52d1581d6129a
CL description should start with "net/http: " then a short summary line (max ~76 char), followed by a blank line, followed by anything else you need to add (probably nothing here) and then just
"Fixes Issue nnnnn" (with or without a trailing period)
No need for the full URL to the bug. Tools link it.
Message from bradfitz@golang.org
2014-03-04T16:39:26+00:00bradfitzurn:md5:c035e615e25766070e38205b9e61c7fa
(run `hg change 70990044` to change it)
Message from mattAimonetti@gmail.com
2014-03-04T17:37:50+00:00mattettiurn:md5:92d9e40642d27e135eb02bf92e1466f7
On 2014/03/04 16:39:26, bradfitz wrote:
> (run `hg change 70990044` to change it)
updated, thanks Brad!
Message from bradfitz@golang.org
2014-03-04T18:07:20+00:00bradfitzurn:md5:bcb26e522417d7744b30d406c096871e
The summary should start with a verb generally. And a period between
Request and ParseForm. See "hg log" for examples.
For instance "net/http: make Request.ParseForm parse form-urlencoded for
method PATCH too"
Out of curiosity, I did:
$ hg log | grep ^summary | grep -v release-branch | perl -npe
's/.+?:.+?:\s*(\S+).+/$1/' | sort | uniq -c | sort -n -r | head -40
2305 fix
1485 add
468 use
438 remove
404 make
312 update
270 don't
179 document
168 do
162 allow
141 support
136 implement
136 handle
136 avoid
124 move
122 delete
115 more
111 change
106 disable
99 Add
98 correct
92 new
88 Fix
81 better
76 improve
70 clarify
68 minor
67 rename
63 simplify
62 enable
59 added
58 test
54 replace
54 faster
50 ignore
50 check
45 include
43 skip
41 clean
40 set
On Tue, Mar 4, 2014 at 9:37 AM, <mattAimonetti@gmail.com> wrote:
> On 2014/03/04 16:39:26, bradfitz wrote:
>
>> (run `hg change 70990044` to change it)
>>
>
> updated, thanks Brad!
>
> https://codereview.appspot.com/70990044/
>
Message from mattAimonetti@gmail.com
2014-03-04T18:25:45+00:00mattettiurn:md5:05a89a1d04ce4fd25e008f0a9d36efcb
On 2014/03/04 18:07:20, bradfitz wrote:
> The summary should start with a verb generally. And a period between
> Request and ParseForm. See "hg log" for examples.
>
> For instance "net/http: make Request.ParseForm parse form-urlencoded for
> method PATCH too"
>
> Out of curiosity, I did:
>
> $ hg log | grep ^summary | grep -v release-branch | perl -npe
> 's/.+?:.+?:\s*(\S+).+/$1/' | sort | uniq -c | sort -n -r | head -40
> 2305 fix
> 1485 add
> 468 use
> 438 remove
> 404 make
> 312 update
> 270 don't
> 179 document
> 168 do
> 162 allow
> 141 support
> 136 implement
> 136 handle
> 136 avoid
> 124 move
> 122 delete
> 115 more
> 111 change
> 106 disable
> 99 Add
> 98 correct
> 92 new
> 88 Fix
> 81 better
> 76 improve
> 70 clarify
> 68 minor
> 67 rename
> 63 simplify
> 62 enable
> 59 added
> 58 test
> 54 replace
> 54 faster
> 50 ignore
> 50 check
> 45 include
> 43 skip
> 41 clean
> 40 set
>
>
>
>
>
> On Tue, Mar 4, 2014 at 9:37 AM, <mailto:mattAimonetti@gmail.com> wrote:
>
> > On 2014/03/04 16:39:26, bradfitz wrote:
> >
> >> (run `hg change 70990044` to change it)
> >>
> >
> > updated, thanks Brad!
> >
> > https://codereview.appspot.com/70990044/
> >
thanks for walking me through the proper process. CL updated.
Message from bradfitz@golang.org
2014-03-04T19:56:10+00:00bradfitzurn:md5:72d9a6d38886d2a5bbae5c1b17161b53
LGTM
Message from bradfitz@golang.org
2014-03-04T19:58:26+00:00bradfitzurn:md5:2f887152955c05a75ce07b99509ade01
*** Submitted as https://code.google.com/p/go/source/detail?r=6102786b4487 ***
net/http: make Request.ParseForm parse form-urlencoded for method PATCH too
Fixes issue 7454
LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/70990044
Committer: Brad Fitzpatrick <bradfitz@golang.org>
Message from gobot@golang.org
2014-03-04T21:29:07+00:00goboturn:md5:d7ebd74915317cdfa9770c918f421167
This CL appears to have broken the darwin-amd64-race-cheney builder.