code review 7004044: net: make unix connection tests more robust

net: make unix connection tests more robust

Avoids unlink the underlying file before the socket close.

[mikio, 2012-12-21 02:08:22]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[dfc, 2012-12-21 04:21:25]

Thank you, just one question.

https://codereview.appspot.com/7004044/diff/3003/src/pkg/net/conn_test.go
File src/pkg/net/conn_test.go (right):

https://codereview.appspot.com/7004044/diff/3003/src/pkg/net/conn_test.go#new...
src/pkg/net/conn_test.go:50: }(ln, tt.net, tt.addr)
very nice.

https://codereview.appspot.com/7004044/diff/3003/src/pkg/net/packetconn_test.go
File src/pkg/net/packetconn_test.go (right):

https://codereview.appspot.com/7004044/diff/3003/src/pkg/net/packetconn_test....
src/pkg/net/packetconn_test.go:66: t.Errorf("net.ListenPacket failed: %v", err)
Why have you converted all these to Errorfs ?

[mikio, 2012-12-21 04:28:07]

On Fri, Dec 21, 2012 at 1:21 PM,  <dave@cheney.net> wrote:

> Why have you converted all these to Errorfs ?

to give a chance to run defer which contains socket/file closers.

[dfc, 2012-12-21 04:32:29]

I don't think that is necessary, defers always run.

lucky(~/t) % cat t_test.go
package t

import "testing"

func TestErrorf(t *testing.T) {
        defer t.Logf("defer in TestErrorf")
        t.Errorf("bang")
}

func TestFatalf(t *testing.T) {
        defer t.Logf("defer in TestFatalf")
        t.Fatalf("boom")
}
lucky(~/t) % go test -v
=== RUN TestErrorf
--- FAIL: TestErrorf (0.00 seconds)
t_test.go:7:    bang
t_test.go:7:    defer in TestErrorf
=== RUN TestFatalf
--- FAIL: TestFatalf (0.00 seconds)
t_test.go:12:   boom
panic.c:91:     defer in TestFatalf
FAIL
exit status 1
FAIL    _/home/dfc/t    0.014s


On Fri, Dec 21, 2012 at 3:28 PM, Mikio Hara <mikioh.mikioh@gmail.com> wrote:
> On Fri, Dec 21, 2012 at 1:21 PM,  <dave@cheney.net> wrote:
>
>> Why have you converted all these to Errorfs ?
>
> to give a chance to run defer which contains socket/file closers.

[mikio, 2012-12-21 04:53:43]

On Fri, Dec 21, 2012 at 1:32 PM, Dave Cheney <dave@cheney.net> wrote:

> I don't think that is necessary, defers always run.

yup, but this test spawns a transponder goroutine and ah... right, thx. ;)

[mikio, 2012-12-21 04:54:50]

Hello golang-dev@googlegroups.com, dave@cheney.net (cc:
golang-dev@googlegroups.com),

Please take another look.

[dfc, 2012-12-21 04:58:11]

LGTM. Thanks.

[mikio, 2012-12-21 05:19:39]

*** Submitted as https://code.google.com/p/go/source/detail?r=72648c5c21a1 ***

net: make unix connection tests more robust

Avoids unlink the underlying file before the socket close.

R=golang-dev, dave
CC=golang-dev
https://codereview.appspot.com/7004044