Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(75)

Issue 7004044: code review 7004044: net: make unix connection tests more robust (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by mikio
Modified:
9 years, 6 months ago
Reviewers:
CC:
golang-dev, dfc
Visibility:
Public.

Description

net: make unix connection tests more robust Avoids unlink the underlying file before the socket close.

Patch Set 1 #

Patch Set 2 : diff -r b9bee6184b4e https://code.google.com/p/go #

Patch Set 3 : diff -r b9bee6184b4e https://code.google.com/p/go #

Total comments: 2

Patch Set 4 : diff -r 7fe729534c6d https://code.google.com/p/go #

Patch Set 5 : diff -r d7a66e98c7a6 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -16 lines) Patch
M src/pkg/net/conn_test.go View 1 3 chunks +9 lines, -7 lines 0 comments Download
M src/pkg/net/packetconn_test.go View 1 2 3 5 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 8
mikio
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
9 years, 6 months ago (2012-12-21 02:08:22 UTC) #1
dfc
Thank you, just one question. https://codereview.appspot.com/7004044/diff/3003/src/pkg/net/conn_test.go File src/pkg/net/conn_test.go (right): https://codereview.appspot.com/7004044/diff/3003/src/pkg/net/conn_test.go#newcode50 src/pkg/net/conn_test.go:50: }(ln, tt.net, tt.addr) very ...
9 years, 6 months ago (2012-12-21 04:21:25 UTC) #2
mikio
On Fri, Dec 21, 2012 at 1:21 PM, <dave@cheney.net> wrote: > Why have you converted ...
9 years, 6 months ago (2012-12-21 04:28:07 UTC) #3
dfc
I don't think that is necessary, defers always run. lucky(~/t) % cat t_test.go package t ...
9 years, 6 months ago (2012-12-21 04:32:29 UTC) #4
mikio
On Fri, Dec 21, 2012 at 1:32 PM, Dave Cheney <dave@cheney.net> wrote: > I don't ...
9 years, 6 months ago (2012-12-21 04:53:43 UTC) #5
mikio
Hello golang-dev@googlegroups.com, dave@cheney.net (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 6 months ago (2012-12-21 04:54:50 UTC) #6
dfc
LGTM. Thanks.
9 years, 6 months ago (2012-12-21 04:58:11 UTC) #7
mikio
9 years, 6 months ago (2012-12-21 05:19:39 UTC) #8
*** Submitted as https://code.google.com/p/go/source/detail?r=72648c5c21a1 ***

net: make unix connection tests more robust

Avoids unlink the underlying file before the socket close.

R=golang-dev, dave
CC=golang-dev
https://codereview.appspot.com/7004044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b