Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(142)

Issue 7002055: code review 7002055: testing: add AllocsPerRun

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by kevlar
Modified:
8 years, 11 months ago
Reviewers:
minux1, rsc
CC:
minux1, rsc, golang-dev
Visibility:
Public.

Description

testing: add AllocsPerRun This CL also replaces similar loops in other stdlib package tests with calls to AllocsPerRun. Fixes issue 4461.

Patch Set 1 #

Patch Set 2 : diff -r b7fd6fe38b63 http://code.google.com/p/go #

Patch Set 3 : diff -r b7fd6fe38b63 http://code.google.com/p/go #

Patch Set 4 : diff -r b7fd6fe38b63 http://code.google.com/p/go #

Patch Set 5 : diff -r b7fd6fe38b63 http://code.google.com/p/go #

Patch Set 6 : diff -r f4e5087c1c19 http://code.google.com/p/go #

Total comments: 4

Patch Set 7 : diff -r f4e5087c1c19 http://code.google.com/p/go #

Patch Set 8 : diff -r f4e5087c1c19 http://code.google.com/p/go #

Patch Set 9 : diff -r f4e5087c1c19 http://code.google.com/p/go #

Total comments: 1

Patch Set 10 : diff -r f50a112bfe3b http://code.google.com/p/go #

Patch Set 11 : diff -r f50a112bfe3b http://code.google.com/p/go #

Total comments: 2

Patch Set 12 : diff -r f50a112bfe3b http://code.google.com/p/go #

Total comments: 26

Patch Set 13 : diff -r f50a112bfe3b http://code.google.com/p/go #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -144 lines) Patch
M src/pkg/encoding/gob/timing_test.go View 1 2 chunks +16 lines, -23 lines 0 comments Download
M src/pkg/fmt/fmt_test.go View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +3 lines, -13 lines 0 comments Download
M src/pkg/net/http/header_test.go View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +19 lines, -27 lines 0 comments Download
M src/pkg/net/rpc/server_test.go View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +5 lines, -13 lines 0 comments Download
M src/pkg/path/filepath/path_test.go View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +4 lines, -13 lines 0 comments Download
M src/pkg/path/path_test.go View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +4 lines, -14 lines 0 comments Download
M src/pkg/reflect/all_test.go View 1 2 chunks +7 lines, -15 lines 0 comments Download
M src/pkg/strconv/strconv_test.go View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +3 lines, -13 lines 0 comments Download
A src/pkg/testing/allocs.go View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +37 lines, -0 lines 1 comment Download
M src/pkg/time/time_test.go View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +3 lines, -13 lines 0 comments Download

Messages

Total messages: 22
kevlar
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to http://code.google.com/p/go
9 years, 6 months ago (2012-12-23 02:20:46 UTC) #1
minux1
Hi Kyle, We also have these tests about mallocs, I think they will all be ...
9 years, 6 months ago (2012-12-23 13:53:56 UTC) #2
kevlar
> Hi Kyle, > We also have these tests about mallocs, I think they will ...
9 years, 6 months ago (2012-12-24 01:00:49 UTC) #3
minux1
i suggest we also return AllocBytes. instead of (*B).Allocs, i think we just need a ...
9 years, 6 months ago (2012-12-24 07:12:36 UTC) #4
kevlar
A lot of the code that's trying to test allocations has to perform some amount ...
9 years, 6 months ago (2012-12-24 07:37:52 UTC) #5
minux1
On Monday, December 24, 2012, kevlar wrote: > A lot of the code that's trying ...
9 years, 6 months ago (2012-12-24 07:47:41 UTC) #6
kevlar
On 2012/12/24 07:12:36, minux wrote: > i suggest we also return AllocBytes. I just tried ...
9 years, 6 months ago (2012-12-24 07:57:07 UTC) #7
kevlar
On Mon, Dec 24, 2012 at 2:47 AM, minux <minux.ma@gmail.com> wrote: > On Monday, December ...
9 years, 6 months ago (2012-12-24 08:02:57 UTC) #8
minux1
On Monday, December 24, 2012, Kyle Lemons wrote: > On Mon, Dec 24, 2012 at ...
9 years, 6 months ago (2012-12-24 08:39:30 UTC) #9
kevlar
I did some more experimenting today. I haven't figured out a way to return both ...
9 years, 6 months ago (2012-12-25 07:57:17 UTC) #10
rsc
Why does the description mention (*B).Allocs? I don't see that anywhere. https://codereview.appspot.com/7002055/diff/15001/src/pkg/exp/html/token_test.go File src/pkg/exp/html/token_test.go (right): ...
9 years, 6 months ago (2012-12-29 19:39:53 UTC) #11
kevlar
On 2012/12/29 19:39:53, rsc wrote: > Why does the description mention (*B).Allocs? I don't see ...
9 years, 6 months ago (2012-12-30 00:50:14 UTC) #12
minux1
On Tue, Dec 25, 2012 at 3:57 PM, <kevlar@google.com> wrote: > I think I agree ...
9 years, 6 months ago (2012-12-30 20:01:26 UTC) #13
kevlar
PTAL There are two alloc-counting tests that didn't convert cleanly: "bytes" TestGrow - seems to ...
9 years, 5 months ago (2013-01-25 08:48:50 UTC) #14
minux1
https://codereview.appspot.com/7002055/diff/26001/api/next.txt File api/next.txt (right): https://codereview.appspot.com/7002055/diff/26001/api/next.txt#newcode1148 api/next.txt:1148: pkg testing, func AllocsPerRun(int, func()) float64 please don't update ...
9 years, 5 months ago (2013-01-25 13:25:10 UTC) #15
kevlar
PTAL On 2013/01/25 13:25:10, minux wrote: > https://codereview.appspot.com/7002055/diff/26001/api/next.txt > File api/next.txt (right): > > https://codereview.appspot.com/7002055/diff/26001/api/next.txt#newcode1148 ...
9 years, 5 months ago (2013-01-26 01:16:36 UTC) #16
minux1
LGTM.
9 years, 5 months ago (2013-01-26 01:25:03 UTC) #17
rsc
Thanks for working on this. It's definitely an improvement in some cases, but not in ...
9 years, 5 months ago (2013-01-30 17:55:41 UTC) #18
kevlar
PTAL Thanks for the comments! https://codereview.appspot.com/7002055/diff/30001/src/pkg/math/big/nat_test.go File src/pkg/math/big/nat_test.go (right): https://codereview.appspot.com/7002055/diff/30001/src/pkg/math/big/nat_test.go#newcode169 src/pkg/math/big/nat_test.go:169: func allocSizePerRun(runs int, f ...
9 years, 5 months ago (2013-01-31 06:14:02 UTC) #19
rsc
LGTM https://codereview.appspot.com/7002055/diff/30003/src/pkg/testing/allocs.go File src/pkg/testing/allocs.go (right): https://codereview.appspot.com/7002055/diff/30003/src/pkg/testing/allocs.go#newcode1 src/pkg/testing/allocs.go:1: package testing missing copyright; i'll add it before ...
9 years, 5 months ago (2013-02-03 03:47:15 UTC) #20
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=b7911b093227 *** testing: add AllocsPerRun This CL also replaces similar loops in ...
9 years, 5 months ago (2013-02-03 03:52:43 UTC) #21
remyoudompheng
8 years, 11 months ago (2013-07-20 20:02:21 UTC) #22
R=close
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b