Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(19)

Issue 7027046: code review 7027046: testing: introduce (*B).EnableMallocReport() (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by minux1
Modified:
9 years, 5 months ago
Reviewers:
CC:
golang-dev, rsc, kevlar, bradfitz
Visibility:
Public.

Description

testing: introduce (*B).ReportAllocs() Calling it will show memory allocation statistics for that single benchmark (if -test.benchmem is not provided)

Patch Set 1 #

Patch Set 2 : diff -r 88ae367d61aa https://code.google.com/p/go/ #

Patch Set 3 : diff -r 88ae367d61aa https://code.google.com/p/go/ #

Patch Set 4 : diff -r 28ee66c9003f https://code.google.com/p/go #

Total comments: 1

Patch Set 5 : diff -r c6a4b0fb079b https://code.google.com/p/go #

Patch Set 6 : diff -r a55bd9f21507 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -20 lines) Patch
M src/pkg/exp/html/parse_test.go View 1 2 3 1 chunk +1 line, -7 lines 0 comments Download
M src/pkg/exp/html/token_test.go View 1 2 3 2 chunks +1 line, -7 lines 0 comments Download
M src/pkg/testing/benchmark.go View 1 2 3 4 3 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 10
minux1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
9 years, 6 months ago (2012-12-30 20:02:20 UTC) #1
rsc
What's wrong with the current behavior (you get it if you ask for it)?
9 years, 6 months ago (2013-01-02 20:00:03 UTC) #2
kevlar
This is related to the AllocsPerRun CL. The two common uses of loops counting allocations ...
9 years, 6 months ago (2013-01-02 20:05:04 UTC) #3
rsc
This sounds like it is conflating benchmarks and tests. Tests run always. Benchmarks do not. ...
9 years, 6 months ago (2013-01-02 20:21:10 UTC) #4
minux1
On Thu, Jan 3, 2013 at 4:00 AM, Russ Cox <rsc@golang.org> wrote: > What's wrong ...
9 years, 6 months ago (2013-01-02 20:55:16 UTC) #5
rsc
How about b.ReportAllocs?
9 years, 6 months ago (2013-01-02 21:16:35 UTC) #6
minux1
On 2013/01/02 21:16:35, rsc wrote: > How about b.ReportAllocs? Sure. PTAL.
9 years, 6 months ago (2013-01-05 12:28:00 UTC) #7
minux1
gentle ping.
9 years, 5 months ago (2013-01-12 17:02:31 UTC) #8
bradfitz
LGTM https://codereview.appspot.com/7027046/diff/8001/src/pkg/testing/benchmark.go File src/pkg/testing/benchmark.go (right): https://codereview.appspot.com/7027046/diff/8001/src/pkg/testing/benchmark.go#newcode96 src/pkg/testing/benchmark.go:96: // like what you get when you pass ...
9 years, 5 months ago (2013-01-12 17:08:52 UTC) #9
minux1
9 years, 5 months ago (2013-01-17 10:46:10 UTC) #10
*** Submitted as https://code.google.com/p/go/source/detail?r=d67c54bb524e ***

testing: introduce (*B).ReportAllocs()
Calling it will show memory allocation statistics for that
single benchmark (if -test.benchmem is not provided)

R=golang-dev, rsc, kevlar, bradfitz
CC=golang-dev
https://codereview.appspot.com/7027046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b