Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6)

Issue 6997047: code review 6997047: cmd/gc: fix eval order in select (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 8 months ago by rsc
Modified:
9 years, 8 months ago
Reviewers:
ken3
CC:
ken2, golang-dev
Visibility:
Public.

Description

cmd/gc: fix eval order in select Ordinary variable load was assumed to be not worth saving, but not if one of the function calls later might change its value. Fixes issue 4313.

Patch Set 1 #

Patch Set 2 : diff -r 21b73dfead26 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 99a549ecc846 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -11 lines) Patch
M src/cmd/gc/order.c View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M src/cmd/gc/select.c View 1 2 chunks +7 lines, -7 lines 0 comments Download
M src/cmd/gc/subr.c View 1 2 1 chunk +3 lines, -1 line 0 comments Download
A test/fixedbugs/issue4313.go View 1 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
9 years, 8 months ago (2012-12-22 21:45:56 UTC) #1
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=1159634f1624 *** cmd/gc: fix eval order in select Ordinary variable load was ...
9 years, 8 months ago (2012-12-22 21:46:06 UTC) #2
ken3
9 years, 8 months ago (2012-12-22 22:48:36 UTC) #3
Message was sent while issue was closed.
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b