Issue 6997047: code review 6997047: cmd/gc: fix eval order in select

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6997047: code review 6997047: cmd/gc: fix eval order in select (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by rsc

Modified:
11 years, 4 months ago

Reviewers:
ken3

CC:
ken2, golang-dev

Visibility:
Public.

Description

cmd/gc: fix eval order in select Ordinary variable load was assumed to be not worth saving, but not if one of the function calls later might change its value. Fixes issue 4313.

Patch Set 1 #

Patch Set 2 : diff -r 21b73dfead26 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 99a549ecc846 https://code.google.com/p/go/ #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -11 lines)			Patch
M	src/cmd/gc/order.c	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/cmd/gc/select.c	View	1	2 chunks	+7 lines, -7 lines	0 comments	Download
M	src/cmd/gc/subr.c	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
A	test/fixedbugs/issue4313.go	View	1	1 chunk	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 4 months ago (2012-12-22 21:45:56 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=1159634f1624 *** cmd/gc: fix eval order in select Ordinary variable load was ...

11 years, 4 months ago (2012-12-22 21:46:06 UTC) #2

Message was sent while issue was closed.

lgtm

Expand All Messages | Collapse All Messages