Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(48)

Issue 6971049: code review 6971049: net/http: fix server connection leak on Handler's panic(nil) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by bradfitz
Modified:
9 years, 6 months ago
Reviewers:
dfc
CC:
golang-dev, adg
Visibility:
Public.

Description

net/http: fix server connection leak on Handler's panic(nil) If a handler did a panic(nil), the connection was never closed. Fixes issue 4050

Patch Set 1 #

Patch Set 2 : diff -r 0c135754c93a https://code.google.com/p/go #

Patch Set 3 : diff -r 0c135754c93a https://code.google.com/p/go #

Patch Set 4 : diff -r 0c135754c93a https://code.google.com/p/go #

Patch Set 5 : diff -r 0c135754c93a https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M src/pkg/net/http/serve_test.go View 1 4 chunks +13 lines, -5 lines 0 comments Download
M src/pkg/net/http/server.go View 1 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 4
bradfitz
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
9 years, 6 months ago (2012-12-19 22:56:21 UTC) #1
adg
LGTM
9 years, 6 months ago (2012-12-19 23:24:47 UTC) #2
bradfitz
*** Submitted as https://code.google.com/p/go/source/detail?r=397a572d7fc9 *** net/http: fix server connection leak on Handler's panic(nil) If a ...
9 years, 6 months ago (2012-12-19 23:39:24 UTC) #3
dfc
9 years, 6 months ago (2012-12-19 23:42:29 UTC) #4
blast, I was too slow. Please consider this as a follow up

https://codereview.appspot.com/6970049

On Thu, Dec 20, 2012 at 10:39 AM,  <bradfitz@golang.org> wrote:
> *** Submitted as
> https://code.google.com/p/go/source/detail?r=397a572d7fc9 ***
>
>
> net/http: fix server connection leak on Handler's panic(nil)
>
> If a handler did a panic(nil), the connection was never closed.
>
> Fixes issue 4050
>
> R=golang-dev, adg
> CC=golang-dev
> https://codereview.appspot.com/6971049
>
>
> https://codereview.appspot.com/6971049/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b