Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(713)

Issue 6970049: code review 6970049: net/http: simplify serve() connection close (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by dfc
Modified:
9 years, 6 months ago
Reviewers:
CC:
bradfitz, golang-dev
Visibility:
Public.

Description

net/http: simplify serve() connection close Followup to 6971049.

Patch Set 1 #

Patch Set 2 : code review 6970049: net/http: fix connection leak on panic #

Patch Set 3 : diff -r 397a572d7fc9 https://code.google.com/p/go #

Total comments: 1

Patch Set 4 : diff -r 1481cdef28a6 https://code.google.com/p/go #

Patch Set 5 : diff -r 1481cdef28a6 https://code.google.com/p/go #

Patch Set 6 : diff -r 1481cdef28a6 https://code.google.com/p/go #

Patch Set 7 : diff -r 95aff3fe5362 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -13 lines) Patch
M src/pkg/net/http/server.go View 1 2 3 5 1 chunk +7 lines, -13 lines 0 comments Download

Messages

Total messages: 5
bradfitz
LGTM sure :) https://codereview.appspot.com/6970049/diff/5001/src/pkg/net/http/server.go File src/pkg/net/http/server.go (right): https://codereview.appspot.com/6970049/diff/5001/src/pkg/net/http/server.go#newcode715 src/pkg/net/http/server.go:715: defer c.close() and delete this line ...
9 years, 6 months ago (2012-12-19 23:56:56 UTC) #1
dfc
Sorry, was working quickly when I saw your proposal. On Thu, Dec 20, 2012 at ...
9 years, 6 months ago (2012-12-20 00:01:46 UTC) #2
dfc
Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
9 years, 6 months ago (2012-12-20 00:58:11 UTC) #3
bradfitz
LGTM
9 years, 6 months ago (2012-12-20 19:35:57 UTC) #4
dfc
9 years, 6 months ago (2012-12-21 04:14:49 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=7fe729534c6d ***

net/http: simplify serve() connection close

Followup to 6971049.

R=bradfitz
CC=golang-dev
https://codereview.appspot.com/6970049
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b