Issue 6970049: code review 6970049: net/http: simplify serve() connection close

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6970049: code review 6970049: net/http: simplify serve() connection close (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by dave

Modified:
11 years, 4 months ago

Reviewers:

CC:
bradfitz, golang-dev

Visibility:
Public.

Description

net/http: simplify serve() connection close Followup to 6971049.

Patch Set 2 : code review 6970049: net/http: fix connection leak on panic #

Patch Set 3 : diff -r 397a572d7fc9 https://code.google.com/p/go #

Total comments: 1

Patch Set 4 : diff -r 1481cdef28a6 https://code.google.com/p/go #

Patch Set 5 : diff -r 1481cdef28a6 https://code.google.com/p/go #

Patch Set 6 : diff -r 1481cdef28a6 https://code.google.com/p/go #

Patch Set 7 : diff -r 95aff3fe5362 https://code.google.com/p/go #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -13 lines)			Patch
	M	src/pkg/net/http/server.go	View	1 2 3 5	1 chunk	+7 lines, -13 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bradfitz

LGTM sure :) https://codereview.appspot.com/6970049/diff/5001/src/pkg/net/http/server.go File src/pkg/net/http/server.go (right): https://codereview.appspot.com/6970049/diff/5001/src/pkg/net/http/server.go#newcode715 src/pkg/net/http/server.go:715: defer c.close() and delete this line ...

11 years, 4 months ago (2012-12-19 23:56:56 UTC) #1

dave_cheney.net

Sorry, was working quickly when I saw your proposal. On Thu, Dec 20, 2012 at ...

11 years, 4 months ago (2012-12-20 00:01:46 UTC) #2

dave_cheney.net

Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 4 months ago (2012-12-20 00:58:11 UTC) #3

dave_cheney.net

11 years, 4 months ago (2012-12-21 04:14:49 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=7fe729534c6d ***

net/http: simplify serve() connection close

Followup to 6971049.

R=bradfitz
CC=golang-dev
https://codereview.appspot.com/6970049

Expand All Messages | Collapse All Messages