Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(195)

Issue 6926049: code review 6926049: 6c/6g/6l/go: PIC and shared library support. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 4 months ago by elias.naur
Modified:
1 year, 2 months ago
Reviewers:
CC:
rsc, iant, golang-dev
Visibility:
Public.

Description

6l/5l: PIC and shared library support for the linkers.

Added the -shared flag to 5l/6l to output a PIC executable with the required
dynamic relocations and RIP-relative addressing in machine code.
Added dummy support to 8l to avoid compilation errors

See also:
https://codereview.appspot.com/6822078
https://codereview.appspot.com/7064048

and

https://groups.google.com/d/topic/golang-nuts/P05BDjLcQ5k/discussion

Patch Set 1 #

Patch Set 2 : diff -r 7b9e9fc59eb5 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 940cccc0f560 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r aa5d9f234a8e https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r aa5d9f234a8e https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r f584af3b870d https://go.googlecode.com/hg/ #

Total comments: 35

Patch Set 7 : diff -r 28ee66c9003f https://go.googlecode.com/hg/ #

Total comments: 10

Patch Set 8 : diff -r 8906cf341c9b https://go.googlecode.com/hg/ #

Patch Set 9 : diff -r c4ee14785641 https://go.googlecode.com/hg/ #

Patch Set 10 : diff -r 9dacae220eca https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+288 lines, -42 lines) Patch
M src/cmd/5l/asm.c View 1 2 3 4 5 6 7 8 8 chunks +58 lines, -4 lines 0 comments Download
M src/cmd/5l/l.h View 1 2 3 4 5 6 7 8 9 6 chunks +6 lines, -0 lines 0 comments Download
M src/cmd/5l/list.c View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/5l/noop.c View 1 2 3 4 5 6 7 2 chunks +19 lines, -0 lines 0 comments Download
M src/cmd/5l/obj.c View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download
M src/cmd/5l/optab.c View 1 2 3 4 5 6 5 chunks +15 lines, -13 lines 0 comments Download
M src/cmd/5l/span.c View 1 2 3 4 5 6 7 4 chunks +22 lines, -9 lines 0 comments Download
M src/cmd/6l/asm.c View 1 2 3 4 5 6 7 2 chunks +15 lines, -1 line 0 comments Download
M src/cmd/6l/l.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download
M src/cmd/6l/obj.c View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download
M src/cmd/6l/span.c View 1 2 3 4 5 6 7 5 chunks +20 lines, -8 lines 0 comments Download
M src/cmd/8l/asm.c View 1 2 3 4 5 6 7 1 chunk +12 lines, -0 lines 0 comments Download
M src/cmd/8l/l.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download
M src/cmd/8l/obj.c View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/ld/data.c View 1 2 3 4 5 6 7 8 12 chunks +78 lines, -5 lines 0 comments Download
M src/cmd/ld/elf.c View 1 2 3 4 5 6 7 3 chunks +14 lines, -1 line 0 comments Download
M src/cmd/ld/go.c View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/ld/lib.h View 1 2 3 4 5 6 7 8 3 chunks +4 lines, -0 lines 0 comments Download
M src/cmd/ld/lib.c View 1 2 3 4 5 6 7 2 chunks +8 lines, -1 line 0 comments Download
M src/cmd/ld/symtab.c View 1 2 3 4 5 6 7 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11
elias.naur
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
1 year, 4 months ago #1
elias.naur
On 2012/12/24 17:32:43, elias.naur wrote: > Hello mailto:golang-dev@googlegroups.com, > > I'd like you to review ...
1 year, 3 months ago #2
rsc
Thanks for working on this. I want to make sure we proceed carefully: there are ...
1 year, 3 months ago #3
elias.naur
PTAL I managed to add linux/arm support (only the linker needed changes), so a look ...
1 year, 3 months ago #4
rsc
There's still more going on here than I'm comfortable doing in one pass. I think ...
1 year, 3 months ago #5
elias.naur
PTAL On Mon, Jan 7, 2013 at 3:24 AM, <rsc@golang.org> wrote: > There's still more ...
1 year, 3 months ago #6
iant
On 2013/01/07 02:24:20, rsc wrote: > > "pic" does not seem to be an accurate ...
1 year, 3 months ago #7
elias.naur
I've hg sync'ed and updated mgc0.c to use relative offsets for the GC_CALL gc instruction, ...
1 year, 3 months ago #8
rsc
LGTM
1 year, 2 months ago #9
rsc
I will submit this without this one line change: //print("gcaddsym: %s %d %s\n", s->name, s->size, ...
1 year, 2 months ago #10
rsc
1 year, 2 months ago #11
*** Submitted as https://code.google.com/p/go/source/detail?r=1eadf11dd1b7 ***

6l/5l: PIC and shared library support for the linkers.

Added the -shared flag to 5l/6l to output a PIC executable with the required
dynamic relocations and RIP-relative addressing in machine code.
Added dummy support to 8l to avoid compilation errors

See also:
https://codereview.appspot.com/6822078
https://codereview.appspot.com/7064048

and

https://groups.google.com/d/topic/golang-nuts/P05BDjLcQ5k/discussion

R=rsc, iant
CC=golang-dev
https://codereview.appspot.com/6926049

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5